linux-kernel - Re: [PATCH v2 1/3] soc: imx8m: Cleanup with adding imx8m_soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250423162918.en4zmphifvot43dt@pengutronix.de>
Date: Wed, 23 Apr 2025 18:29:18 +0200
From: Marco Felsch <m.felsch@...gutronix.de>
To: "Peng Fan (OSS)" <peng.fan@....nxp.com>
Cc: Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Peng Fan <peng.fan@....com>
Subject: Re: [PATCH v2 1/3] soc: imx8m: Cleanup with adding
 imx8m_soc_[un]prepare

On 25-04-23, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@....com>
> 
> There is a common flow to i.MX8M family, map OCOTP register base and
> enable ocotp clk first before read Unique ID from OCOTP.
> 
> So introduce imx8m_soc_prepare to do ioremap and enable the ocotp clk,
> and introduce imx8m_soc_unprepare to disable the clk and do iounmap.

Wouldn't have gone that far, but the changes lgtm.

> With this patch, no need to spread the ioremap and clk handling in
> each soc_revision hook.
> 
> Signed-off-by: Peng Fan <peng.fan@....com>

Reviewed-by: Marco Felsch <m.felsch@...gutronix.de>