linux-kernel - Re: [PATCH v1] platform: Fix race condition during DMA configure at IOMMU probe time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250423165805.GH1213339@ziepe.ca>
Date: Wed, 23 Apr 2025 13:58:05 -0300
From: Jason Gunthorpe <jgg@...pe.ca>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: Will McVicker <willmcvicker@...gle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Danilo Krummrich <dakr@...nel.org>,
	"Rob Herring (Arm)" <robh@...nel.org>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Robin Murphy <robin.murphy@....com>, Joerg Roedel <jroedel@...e.de>,
	Bjorn Helgaas <bhelgaas@...gle.com>, iommu@...ts.linux.dev,
	Saravana Kannan <saravanak@...gle.com>, kernel-team@...roid.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] platform: Fix race condition during DMA configure at
 IOMMU probe time

On Wed, Apr 23, 2025 at 10:08:23AM -0500, Bjorn Helgaas wrote:
> I think this would all be clearer if we tested for the NULL pointer
> explicitly before applying to_platform_driver().  I don't like setting
> a pointer to an invalid value.  I think it's better if the pointer is
> either valid or uninitialized because the compiler can help find uses
> of uninitialized pointers.

+1

Jason