linux-kernel - Re: [PATCH perf/core 12/22] selftests/bpf: Reorg the uprobe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzZZmF7f2n9OzhRfZAt4LkUnSSjo27P+2vfD=sc6FThgkQ@mail.gmail.com>
Date: Wed, 23 Apr 2025 10:34:20 -0700
From: Andrii Nakryiko <andrii.nakryiko@...il.com>
To: Jiri Olsa <jolsa@...nel.org>
Cc: Oleg Nesterov <oleg@...hat.com>, Peter Zijlstra <peterz@...radead.org>, 
	Andrii Nakryiko <andrii@...nel.org>, bpf@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-trace-kernel@...r.kernel.org, x86@...nel.org, 
	Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>, 
	John Fastabend <john.fastabend@...il.com>, Hao Luo <haoluo@...gle.com>, 
	Steven Rostedt <rostedt@...dmis.org>, Masami Hiramatsu <mhiramat@...nel.org>, 
	Alan Maguire <alan.maguire@...cle.com>, David Laight <David.Laight@...lab.com>, 
	Thomas Weißschuh <thomas@...ch.de>, 
	Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH perf/core 12/22] selftests/bpf: Reorg the uprobe_syscall
 test function

On Mon, Apr 21, 2025 at 2:46 PM Jiri Olsa <jolsa@...nel.org> wrote:
>
> Adding __test_uprobe_syscall with non x86_64 stub to execute all the tests,
> so we don't need to keep adding non x86_64 stub functions for new tests.
>
> Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> ---
>  .../selftests/bpf/prog_tests/uprobe_syscall.c | 34 +++++++------------
>  1 file changed, 12 insertions(+), 22 deletions(-)
>

Acked-by: Andrii Nakryiko <andrii@...nel.org>

> diff --git a/tools/testing/selftests/bpf/prog_tests/uprobe_syscall.c b/tools/testing/selftests/bpf/prog_tests/uprobe_syscall.c
> index c397336fe1ed..2b00f16406c8 100644
> --- a/tools/testing/selftests/bpf/prog_tests/uprobe_syscall.c
> +++ b/tools/testing/selftests/bpf/prog_tests/uprobe_syscall.c
> @@ -350,29 +350,8 @@ static void test_uretprobe_shadow_stack(void)
>
>         ARCH_PRCTL(ARCH_SHSTK_DISABLE, ARCH_SHSTK_SHSTK);
>  }
> -#else
> -static void test_uretprobe_regs_equal(void)
> -{
> -       test__skip();
> -}
> -
> -static void test_uretprobe_regs_change(void)
> -{
> -       test__skip();
> -}
> -
> -static void test_uretprobe_syscall_call(void)
> -{
> -       test__skip();
> -}
>
> -static void test_uretprobe_shadow_stack(void)
> -{
> -       test__skip();
> -}
> -#endif
> -
> -void test_uprobe_syscall(void)
> +static void __test_uprobe_syscall(void)
>  {
>         if (test__start_subtest("uretprobe_regs_equal"))
>                 test_uretprobe_regs_equal();
> @@ -383,3 +362,14 @@ void test_uprobe_syscall(void)
>         if (test__start_subtest("uretprobe_shadow_stack"))
>                 test_uretprobe_shadow_stack();
>  }
> +#else
> +static void __test_uprobe_syscall(void)
> +{
> +       test__skip();
> +}
> +#endif
> +
> +void test_uprobe_syscall(void)
> +{
> +       __test_uprobe_syscall();
> +}
> --
> 2.49.0
>