linux-kernel - Re: [PATCH v2 1/4] mm/hugetlb: Refactor unmap_ref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aAhbxQxMFAvsOrx0@casper.infradead.org>
Date: Wed, 23 Apr 2025 04:17:25 +0100
From: Matthew Wilcox <willy@...radead.org>
To: nifan.cxl@...il.com
Cc: muchun.song@...ux.dev, mcgrof@...nel.org, a.manzanares@...sung.com,
	dave@...olabs.net, akpm@...ux-foundation.org, david@...hat.com,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Fan Ni <fan.ni@...sung.com>,
	Sidhartha Kumar <sidhartha.kumar@...cle.com>
Subject: Re: [PATCH v2 1/4] mm/hugetlb: Refactor unmap_ref_private() to take
 folio instead of page


With regard to the Subject: line, you're not "refactoring".  You're
passing a folio to the function.

> @@ -6108,7 +6108,8 @@ static void unmap_ref_private(struct mm_struct *mm, struct vm_area_struct *vma,
>  		 */
>  		if (!is_vma_resv_set(iter_vma, HPAGE_RESV_OWNER))
>  			unmap_hugepage_range(iter_vma, address,
> -					     address + huge_page_size(h), page, 0);
> +					     address + huge_page_size(h),
> +					     folio_page(folio, 0), 0);

As previously, use &folio->page here.