linux-kernel - Re: [PATCH v3 0/2] drm/ci: Add devicetree validation and KUnit tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b7795d63-ca8c-4746-84aa-49793d1b6852@igalia.com>
Date: Wed, 23 Apr 2025 15:51:01 -0300
From: Helen Koike <koike@...lia.com>
To: Vignesh Raman <vignesh.raman@...labora.com>,
 dri-devel@...ts.freedesktop.org
Cc: daniels@...labora.com, daniel@...ishbar.org, helen.fornazier@...il.com,
 airlied@...il.com, simona.vetter@...ll.ch, robdclark@...il.com,
 guilherme.gallo@...labora.com, sergi.blanch.torne@...labora.com,
 valentine.burley@...labora.com, lumag@...nel.org,
 dmitry.baryshkov@....qualcomm.com, quic_abhinavk@...cinc.com,
 mripard@...nel.org, maarten.lankhorst@...ux.intel.com, tzimmermann@...e.de,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/2] drm/ci: Add devicetree validation and KUnit tests

Hi Vignesh,

Thanks for this version, please see my comments below.

On 17/04/2025 00:04, Vignesh Raman wrote:
> Add jobs to validate devicetrees and run KUnit tests.
> 
> Pipeline link,
> https://gitlab.freedesktop.org/vigneshraman/linux/-/pipelines/1407489

I see this message:

WARNING: Running pip as the 'root' user can result in broken permissions 
and conflicting behaviour with the system package manager. It is 
recommended to use a virtual environment instead: 
https://pip.pypa.io/warnings/venv


It would be nice to fix this at some point.

With or without this, for the entire series:

Acked-by: Helen Koike <helen.fornazier@...il.com>

Thanks
Helen

> 
> Link to v1,
> https://lore.kernel.org/all/20250327160117.945165-1-vignesh.raman@collabora.com/
> 
> Link to v2,
> https://lore.kernel.org/all/20250409061543.311184-1-vignesh.raman@collabora.com/
> 
> Vignesh Raman (2):
>    drm/ci: Add jobs to validate devicetrees
>    drm/ci: Add jobs to run KUnit tests
> 
>   drivers/gpu/drm/ci/check-devicetrees.yml | 44 ++++++++++++++++++++++++
>   drivers/gpu/drm/ci/dt-binding-check.sh   | 16 +++++++++
>   drivers/gpu/drm/ci/dtbs-check.sh         | 19 ++++++++++
>   drivers/gpu/drm/ci/gitlab-ci.yml         |  4 +++
>   drivers/gpu/drm/ci/kunit.sh              | 11 ++++++
>   drivers/gpu/drm/ci/kunit.yml             | 33 ++++++++++++++++++
>   6 files changed, 127 insertions(+)
>   create mode 100644 drivers/gpu/drm/ci/check-devicetrees.yml
>   create mode 100755 drivers/gpu/drm/ci/dt-binding-check.sh
>   create mode 100755 drivers/gpu/drm/ci/dtbs-check.sh
>   create mode 100755 drivers/gpu/drm/ci/kunit.sh
>   create mode 100644 drivers/gpu/drm/ci/kunit.yml
>