linux-kernel - Re: [PATCH v2 ratelimit 11/14] ratelimit: Force re-initialization when rate-limiting re-enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <98e5ab65-7601-452e-9ebc-bb3a7426313e@sirena.org.uk>
Date: Wed, 23 Apr 2025 19:59:11 +0100
From: Mark Brown <broonie@...nel.org>
To: "Paul E. McKenney" <paulmck@...nel.org>
Cc: linux-kernel@...r.kernel.org, kernel-team@...a.com,
	Andrew Morton <akpm@...ux-foundation.org>,
	Kuniyuki Iwashima <kuniyu@...zon.com>,
	Mateusz Guzik <mjguzik@...il.com>, Petr Mladek <pmladek@...e.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	John Ogness <john.ogness@...utronix.de>,
	Sergey Senozhatsky <senozhatsky@...omium.org>,
	Jon Pan-Doh <pandoh@...gle.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Karolina Stolarek <karolina.stolarek@...cle.com>,
	Aishwarya.TCV@....com, sraithal@....com
Subject: Re: [PATCH v2 ratelimit 11/14] ratelimit: Force re-initialization
 when rate-limiting re-enabled

On Wed, Apr 23, 2025 at 11:20:59AM -0700, Paul E. McKenney wrote:
> On Wed, Apr 23, 2025 at 04:59:49PM +0100, Mark Brown wrote:

> They reported that the replacing the offending commit with the following
> patch fixed things up:

>  
> -	if (!interval || !burst)
> +	if (interval <= 0 || burst <= 0)
>  		return 1;
>  

That fixes things, yes.

> If that fixes things for you, could you also please try the following,
> also replacing that same commit?

>  
> -	if (!interval || !burst)
> +	if (interval <= 0 || burst <= 0) {
> +		ret = burst > 0;
>  		return 1;
> +	}

Are you sure about that - the value set for ret will be ignored, we
still return 1 regardless of the value of burst as for the first patch
AFAICT?  I tried instead:

+	if (interval <= 0 || burst <= 0) {
+		return burst > 0;
+	}

which failed.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)