linux-kernel - Re: [PATCH] crypto: engine - Realign struct crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aAhhWhB1tLHlRGHR@gondor.apana.org.au>
Date: Wed, 23 Apr 2025 11:41:14 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: "David S. Miller" <davem@...emloft.net>, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: engine - Realign struct crypto_engine to save 8
 bytes

On Fri, Apr 18, 2025 at 12:36:49AM +0200, Thorsten Blum wrote:
> Realign struct crypto_engine to reduce its size by 8 bytes. Total size
> is now 192 bytes, allowing it to fit within 3 cachelines instead of 4.
> 
> pahole output before:
> 
>   /* size: 200, cachelines: 4, members: 17 */
>   /* sum members: 183, holes: 3, sum holes: 17 */
>   /* paddings: 1, sum paddings: 4 */
>   /* last cacheline: 8 bytes */
> 
> and after:
> 
>   /* size: 192, cachelines: 3, members: 17 */
>   /* sum members: 183, holes: 2, sum holes: 9 */
>   /* paddings: 1, sum paddings: 4 */
> 
> No functional changes intended.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>  include/crypto/internal/engine.h | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt