linux-kernel - Re: [PATCH] eisa: address link failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202504231224.1A2A116@keescook>
Date: Wed, 23 Apr 2025 12:24:46 -0700
From: Kees Cook <kees@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alejandro Colomar <alx@...nel.org>, Arnd Bergmann <arnd@...db.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] eisa: address link failure

On Wed, Apr 23, 2025 at 06:27:50PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The devlist.h file is generated at build time but is not an object file,
> so linking fails, at least in some configurations:
> 
> ld.lld-21: error: vmlinux.a(drivers/eisa/devlist.h): not an ELF file
> 
> Make this an extra-y instead of obj-y target in Kbuild.
> 
> Fixes: dd09eb0e2cc4 ("EISA: Increase length of device names")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks! I already sent this one:

https://lore.kernel.org/all/20250423023743.work.350-kees@kernel.org/

-Kees

> ---
>  drivers/eisa/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/eisa/Makefile b/drivers/eisa/Makefile
> index f0d6cf7d1f32..562d8797e3b4 100644
> --- a/drivers/eisa/Makefile
> +++ b/drivers/eisa/Makefile
> @@ -1,7 +1,8 @@
>  # SPDX-License-Identifier: GPL-2.0
>  # Makefile for the Linux device tree
>  
> -obj-$(CONFIG_EISA)	        += devlist.h eisa-bus.o
> +obj-$(CONFIG_EISA)	        += eisa-bus.o
> +extra-$(CONFIG_EISA)		+= devlist.h
>  obj-${CONFIG_EISA_PCI_EISA}     += pci_eisa.o
>  
>  # virtual_root.o should be the last EISA root device to initialize,
> -- 
> 2.39.5
> 

-- 
Kees Cook