linux-kernel - Re: [PATCH] ASoC: wm8998: Add Kconfig prompt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <967a33de6bd994c6675fef8acd53508d19c917dc.camel@apitzsch.eu>
Date: Wed, 23 Apr 2025 21:37:44 +0200
From: André Apitzsch <git@...tzsch.eu>
To: Richard Fitzgerald <rf@...nsource.cirrus.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, 
 Jaroslav Kysela
	 <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, 
	~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org, 
	linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org, Charles Keepax
	 <ckeepax@...nsource.cirrus.com>
Subject: Re: [PATCH] ASoC: wm8998: Add Kconfig prompt

Am Mittwoch, dem 23.04.2025 um 12:09 +0100 schrieb Richard Fitzgerald:
> On 21/4/25 15:15, Charles Keepax wrote:
> > On Fri, Apr 18, 2025 at 10:22:04PM +0200, André Apitzsch via B4
> > Relay wrote:
> > > From: André Apitzsch <git@...tzsch.eu>
> > > 
> > > Add tristate prompt to allow codec selection.
> > > 
> > > Signed-off-by: André Apitzsch <git@...tzsch.eu>
> > > ---
> > 
> > Generally its good to say why one wants to make the symbol
> > selectable, usually its to use it with simple card, although at
> > least historically I think simple card struggled to handle the
> > required set_sysclk calls for these codecs.
> > 
> > But I have no objection to this being exported:
> > 
> > Reviewed-by: Charles Keepax <ckeepax@...nsource.cirrus.com>
> > 
> > Thanks,
> > Charles
> 
> Yeah, I just checked simple-card and friends and I see no evidence
> that it has a way to make the necessary calls to enable the clocks
> and PLL on the WM8998.
> 
> Of course, the intended machine driver might not be simple/audio-
> graph so that might not be a problem. Though a more specific machine
> driver could simply select the codec driver it uses.
> 
> This is why it helps to say why you need this change.

Hi,

the WM8998 is used by the BQ Aquaris M5 [1]. I forgot to mention it in
the commit message.

Best regards,
André


[1] https://wiki.postmarketos.org/wiki/BQ_Aquaris_M5_(bq-piccolo)