| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250423201826.1054254-1-yakoyoku@gmail.com>
Date: Wed, 23 Apr 2025 17:18:25 -0300
From: Martin Rodriguez Reboredo <yakoyoku@...il.com>
To: linux-wireless@...r.kernel.org
Cc: Jes Sorensen <Jes.Sorensen@...il.com>,
Ping-Ke Shih <pkshih@...ltek.com>,
linux-kernel@...r.kernel.org
Subject: [RFC PATCH] wifi: rtl8xxxu: toggle P2P for supported devices
This is an RFC to see if rtl8xxxu can be made to support P2P.
Theoretically this should be handled by mac80211 but it seems that
drivers may have to take some extra steps depending on which device we
are talking about. I know that this patch is so basic that it might be
missing some H2C commands or similar for this to work on Realtek chips
but I don't have the required knowledge for me to implement it, so if
you know a place to read about I'll be glad to hear.
As of now only rtl8192ex devices will have their P2P_CLIENT, P2P_GO
and P2P_DEVICE wiphy interface modes set because those are the only
ones I can test on my rtl8192eu card.
Signed-off-by: Martin Rodriguez Reboredo <yakoyoku@...il.com>
---
drivers/net/wireless/realtek/rtl8xxxu/8192e.c | 3 ++
drivers/net/wireless/realtek/rtl8xxxu/core.c | 34 ++++++++++++++++++-
.../net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 3 ++
3 files changed, 39 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtl8xxxu/8192e.c b/drivers/net/wireless/realtek/rtl8xxxu/8192e.c
index 8e123bbfc665..3e78c5b73726 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/8192e.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/8192e.c
@@ -1752,6 +1752,9 @@ struct rtl8xxxu_fileops rtl8192eu_fops = {
.gen2_thermal_meter = 1,
.needs_full_init = 1,
.supports_ap = 1,
+ .supports_p2p_client = 1,
+ .supports_p2p_go = 1,
+ .supports_p2p_device = 1,
.max_macid_num = 128,
.max_sec_cam_num = 64,
.adda_1t_init = 0x0fc01616,
diff --git a/drivers/net/wireless/realtek/rtl8xxxu/core.c b/drivers/net/wireless/realtek/rtl8xxxu/core.c
index 569856ca677f..a86c4a9083b2 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/core.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/core.c
@@ -1600,9 +1600,11 @@ static void rtl8xxxu_set_linktype(struct rtl8xxxu_priv *priv,
case NL80211_IFTYPE_ADHOC:
type = MSR_LINKTYPE_ADHOC;
break;
+ case NL80211_IFTYPE_P2P_CLIENT:
case NL80211_IFTYPE_STATION:
type = MSR_LINKTYPE_STATION;
break;
+ case NL80211_IFTYPE_P2P_GO:
case NL80211_IFTYPE_AP:
type = MSR_LINKTYPE_AP;
break;
@@ -6780,6 +6782,8 @@ static int rtl8xxxu_add_interface(struct ieee80211_hw *hw,
return -EOPNOTSUPP;
switch (vif->type) {
+ case NL80211_IFTYPE_P2P_CLIENT:
+ fallthrough;
case NL80211_IFTYPE_STATION:
if (port_num == 0) {
rtl8xxxu_stop_tx_beacon(priv);
@@ -6790,6 +6794,8 @@ static int rtl8xxxu_add_interface(struct ieee80211_hw *hw,
rtl8xxxu_write8(priv, REG_BEACON_CTRL, val8);
}
break;
+ case NL80211_IFTYPE_P2P_GO:
+ fallthrough;
case NL80211_IFTYPE_AP:
if (port_num == 1) {
rtl8xxxu_switch_ports(priv);
@@ -6839,6 +6845,23 @@ static void rtl8xxxu_remove_interface(struct ieee80211_hw *hw,
priv->vifs[rtlvif->port_num] = NULL;
}
+static int rtl8xxxu_change_interface(struct ieee80211_hw *hw,
+ struct ieee80211_vif *vif,
+ enum nl80211_iftype new_type, bool p2p)
+{
+ struct rtl8xxxu_priv *priv = hw->priv;
+ int ret;
+
+ dev_dbg(&priv->udev->dev, "%s: p2p %x\n", __func__, p2p);
+
+ rtl8xxxu_remove_interface(hw, vif);
+ vif->type = new_type;
+ vif->p2p = p2p;
+ ret = rtl8xxxu_add_interface(hw, vif);
+
+ return ret;
+}
+
static int rtl8xxxu_config(struct ieee80211_hw *hw, u32 changed)
{
struct rtl8xxxu_priv *priv = hw->priv;
@@ -7623,6 +7646,7 @@ static const struct ieee80211_ops rtl8xxxu_ops = {
.tx = rtl8xxxu_tx,
.wake_tx_queue = ieee80211_handle_wake_tx_queue,
.add_interface = rtl8xxxu_add_interface,
+ .change_interface = rtl8xxxu_change_interface,
.remove_interface = rtl8xxxu_remove_interface,
.config = rtl8xxxu_config,
.conf_tx = rtl8xxxu_conf_tx,
@@ -7755,7 +7779,9 @@ static void rtl8xxxu_deinit_led(struct rtl8xxxu_priv *priv)
static const struct ieee80211_iface_limit rtl8xxxu_limits[] = {
{ .max = 2, .types = BIT(NL80211_IFTYPE_STATION), },
- { .max = 1, .types = BIT(NL80211_IFTYPE_AP), },
+ { .max = 1, .types = BIT(NL80211_IFTYPE_AP) |
+ BIT(NL80211_IFTYPE_P2P_CLIENT) |
+ BIT(NL80211_IFTYPE_P2P_GO), },
};
static const struct ieee80211_iface_combination rtl8xxxu_combinations[] = {
@@ -7912,6 +7938,12 @@ static int rtl8xxxu_probe(struct usb_interface *interface,
hw->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION);
if (priv->fops->supports_ap)
hw->wiphy->interface_modes |= BIT(NL80211_IFTYPE_AP);
+ if (priv->fops->supports_p2p_client)
+ hw->wiphy->interface_modes |= BIT(NL80211_IFTYPE_P2P_CLIENT);
+ if (priv->fops->supports_p2p_go)
+ hw->wiphy->interface_modes |= BIT(NL80211_IFTYPE_P2P_GO);
+ if (priv->fops->supports_p2p_device)
+ hw->wiphy->interface_modes |= BIT(NL80211_IFTYPE_P2P_DEVICE);
hw->queues = 4;
hw->wiphy->flags |= WIPHY_FLAG_HAS_CHANNEL_SWITCH;
diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h
index f42463e595cc..954f3fc24ce8 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h
@@ -2013,6 +2013,9 @@ struct rtl8xxxu_fileops {
u8 ustime_tsf_edca;
u16 max_aggr_num;
u8 supports_ap:1;
+ u8 supports_p2p_client:1;
+ u8 supports_p2p_go:1;
+ u8 supports_p2p_device:1;
u16 max_macid_num;
u16 max_sec_cam_num;
u32 adda_1t_init;
--
2.49.0
Powered by blists - more mailing lists