linux-kernel - Re: [PATCH v4 1/2] perf trace: Implement syscall summary in BPF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aAlSqGN9Sx4x6_sI@x1>
Date: Wed, 23 Apr 2025 17:50:48 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Namhyung Kim <namhyung@...nel.org>
Cc: Howard Chu <howardchu95@...il.com>, Ian Rogers <irogers@...gle.com>,
	Kan Liang <kan.liang@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
	linux-perf-users@...r.kernel.org, Song Liu <song@...nel.org>,
	bpf@...r.kernel.org
Subject: Re: [PATCH v4 1/2] perf trace: Implement syscall summary in BPF

On Wed, Apr 23, 2025 at 10:41:55AM -0700, Namhyung Kim wrote:
> Hi Arnaldo,
> 
> On Wed, Apr 23, 2025 at 01:26:48PM -0300, Arnaldo Carvalho de Melo wrote:
> > On Fri, Mar 28, 2025 at 06:46:36PM -0700, Howard Chu wrote:
> > > On Tue, Mar 25, 2025 at 9:40 PM Namhyung Kim <namhyung@...nel.org> wrote:
> > > >      syscall            calls  errors  total       min       avg       max       stddev
> > > >                                        (msec)    (msec)    (msec)    (msec)        (%)
> > > >      --------------- --------  ------ -------- --------- --------- ---------     ------
> > > >      epoll_wait           561      0  4530.843     0.000     8.076   520.941     18.75%
> > > >      futex                693     45  4317.231     0.000     6.230   500.077     21.98%
> > > >      poll                 300      0  1040.109     0.000     3.467   120.928     17.02%
> > > >      clock_nanosleep        1      0  1000.172  1000.172  1000.172  1000.172      0.00%
> > > >      ppoll                360      0   872.386     0.001     2.423   253.275     41.91%
> > > >      epoll_pwait           14      0   384.349     0.001    27.453   380.002     98.79%
> > > >      pselect6              14      0   108.130     7.198     7.724     8.206      0.85%
> > > >      nanosleep             39      0    43.378     0.069     1.112    10.084     44.23%
> > > >      ...
> > 
> > I added the following to align sched_[gs]etaffinity,
> 
> Thanks for processing the patch and updating this.  But I'm afraid there
> are more syscalls with longer names and this is not the only place to
> print the syscall names.  Also I think we need to update length of the
> time fields.  So I prefer handling them in a separate patch later.

Fair enough, I'm leaving the patch as-is.

- Arnaldo