linux-kernel - Re: [PATCH net-next 0/6] gve: Add Rx HW timestamping support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99b52c22-c797-4291-92ad-39eaf041ae8c@linux.dev>
Date: Wed, 23 Apr 2025 22:06:22 +0100
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Ziwei Xiao <ziweixiao@...gle.com>
Cc: Harshitha Ramamurthy <hramamurthy@...gle.com>, netdev@...r.kernel.org,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, jeroendb@...gle.com, andrew+netdev@...n.ch,
 willemb@...gle.com, pkaligineedi@...gle.com, yyd@...gle.com,
 joshwash@...gle.com, shailend@...gle.com, linux@...blig.org,
 thostet@...gle.com, jfraker@...gle.com, horms@...nel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 0/6] gve: Add Rx HW timestamping support

On 23/04/2025 21:46, Ziwei Xiao wrote:
> On Wed, Apr 23, 2025 at 3:13 AM Vadim Fedorenko
> <vadim.fedorenko@...ux.dev> wrote:
>>
>> On 18/04/2025 23:12, Harshitha Ramamurthy wrote:
>>> From: Ziwei Xiao <ziweixiao@...gle.com>
>>>
>>> This patch series add the support of Rx HW timestamping, which sends
>>> adminq commands periodically to the device for clock synchronization with
>>> the nic.
>>
>> It looks more like other PHC devices, but no PTP clock is exported. Do
>> you plan to implement TX HW timestamps for this device later?
>> Is it possible to use timecounter to provide proper PTP device on top of
>> GVE?
> Yes, the TX HW timestamps and PTP device work is undergoing. Those
> would be sent out in separate patch series when they are ready.

It looks like it's better to have PTP device ready firts as it
definitely needs some worker to keep time counting. And it should be
done with ptp::aux_work and replace the work you introduced in patch 3
of this series.

>>
>>>
>>> John Fraker (5):
>>>     gve: Add device option for nic clock synchronization
>>>     gve: Add adminq command to report nic timestamp.
>>>     gve: Add rx hardware timestamp expansion
>>>     gve: Add support for SIOC[GS]HWTSTAMP IOCTLs
>>>     gve: Advertise support for rx hardware timestamping
>>>
>>> Kevin Yang (1):
>>>     gve: Add initial gve_clock
>>>
>>>    drivers/net/ethernet/google/gve/Makefile      |   2 +-
>>>    drivers/net/ethernet/google/gve/gve.h         |  14 +++
>>>    drivers/net/ethernet/google/gve/gve_adminq.c  |  51 ++++++++-
>>>    drivers/net/ethernet/google/gve/gve_adminq.h  |  26 +++++
>>>    drivers/net/ethernet/google/gve/gve_clock.c   | 103 ++++++++++++++++++
>>>    .../net/ethernet/google/gve/gve_desc_dqo.h    |   3 +-
>>>    drivers/net/ethernet/google/gve/gve_ethtool.c |  23 +++-
>>>    drivers/net/ethernet/google/gve/gve_main.c    |  47 ++++++++
>>>    drivers/net/ethernet/google/gve/gve_rx_dqo.c  |  26 +++++
>>>    9 files changed, 290 insertions(+), 5 deletions(-)
>>>    create mode 100644 drivers/net/ethernet/google/gve/gve_clock.c
>>>
>>