linux-kernel - Re: [PATCH] bnxt_en: hide CONFIG_DETECT_HUNG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d554487a-a328-42af-8dc3-16dcac127663@intel.com>
Date: Wed, 23 Apr 2025 15:10:55 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Michael Chan <michael.chan@...adcom.com>, Arnd Bergmann <arnd@...nel.org>
CC: Pavan Chebbi <pavan.chebbi@...adcom.com>, Andrew Lunn
	<andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Kalesh AP <kalesh-anakkur.purayil@...adcom.com>, "Andy
 Gospodarek" <andrew.gospodarek@...adcom.com>, Arnd Bergmann <arnd@...db.de>,
	Somnath Kotur <somnath.kotur@...adcom.com>, Simon Horman <horms@...nel.org>,
	Taehee Yoo <ap420073@...il.com>, David Wei <dw@...idwei.uk>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bnxt_en: hide CONFIG_DETECT_HUNG_TASK specific code



On 4/23/2025 10:28 AM, Michael Chan wrote:
> On Wed, Apr 23, 2025 at 9:28 AM Arnd Bergmann <arnd@...nel.org> wrote:
>>
>> From: Arnd Bergmann <arnd@...db.de>
>>
>> The CONFIG_DEFAULT_HUNG_TASK_TIMEOUT setting is only available when the
>> hung task detection is enabled, otherwise the code now produces a build
>> failure:
>>
>> drivers/net/ethernet/broadcom/bnxt/bnxt.c:10188:21: error: use of undeclared identifier 'CONFIG_DEFAULT_HUNG_TASK_TIMEOUT'
>>  10188 |             max_tmo_secs > CONFIG_DEFAULT_HUNG_TASK_TIMEOUT) {
>>
>> Enclose this warning logic in an #ifdef to ensure this builds.
>>
>> Fixes: 0fcad44a86bd ("bnxt_en: Change FW message timeout warning")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> I also cannot think of a better way, so this looks fine to me.  Thanks.
> Reviewed-by: Michael Chan <michael.chan@...adcom.com>

I ran into this just now, and this fixed compilation for me.

Tested-by: Jacob Keller <jacob.e.keller@...el.com>