linux-kernel - Re: [PATCH] Input: cyttsp5 - fix power control issue on wakeup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025042327-stunning-backside-2849@gregkh>
Date: Wed, 23 Apr 2025 08:12:42 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Hugo Villeneuve <hugo@...ovil.com>
Cc: Linus Walleij <linus.walleij@...aro.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Maximilian Weigand <mweigand@...igand.net>,
	Alistair Francis <alistair@...stair23.me>,
	Mikael Gonella-Bolduc <mgonellabolduc@...onoff.com>,
	stable@...r.kernel.org, Hugo Villeneuve <hvilleneuve@...onoff.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: cyttsp5 - fix power control issue on wakeup

On Tue, Apr 22, 2025 at 02:50:26PM -0400, Hugo Villeneuve wrote:
> On Tue, 22 Apr 2025 14:43:24 -0400
> Hugo Villeneuve <hugo@...ovil.com> wrote:
> 
> > From: Mikael Gonella-Bolduc <mgonellabolduc@...onoff.com>
> > 
> > The power control function ignores the "on" argument when setting the
> > report ID, and thus is always sending HID_POWER_SLEEP. This causes a
> > problem when trying to wakeup.
> > 
> > Fix by sending the state variable, which contains the proper HID_POWER_ON or
> > HID_POWER_SLEEP based on the "on" argument.
> > 
> > Fixes: 3c98b8dbdced ("Input: cyttsp5 - implement proper sleep and wakeup procedures")
> > Cc: stable@...r.kernel.org
> > Signed-off-by: Hugo Villeneuve <hvilleneuve@...onoff.com>
> 
> I inadvertently removed Mikael SOB tag, I can re-add it if a V2 is
> needed.

You can't remove it, please add it back.