linux-kernel - Re: [PATCH v6 0/4] Add static channel mapping between soundwire master and slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <98F1324C86982D2B+13f97453-f1ec-4c08-977b-c1bd9a68d409@radxa.com>
Date: Wed, 23 Apr 2025 14:47:12 +0800
From: Xilin Wu <sophon@...xa.com>
To: Mohammad Rafi Shaik <quic_mohs@...cinc.com>,
 Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Vinod Koul <vkoul@...nel.org>,
 Bard Liao <yung-chuan.liao@...ux.intel.com>, Jaroslav Kysela
 <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>,
 Sanyog Kale <sanyog.r.kale@...el.com>, linux-arm-msm@...r.kernel.org,
 linux-sound@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, quic_pkumpatl@...cinc.com,
 kernel@....qualcomm.com
Subject: Re: [PATCH v6 0/4] Add static channel mapping between soundwire
 master and slave

On 2025/4/22 22:59:13, Xilin Wu wrote:
> On 2025/2/6 19:22:21, Mohammad Rafi Shaik wrote:
>> Add static channel map support between soundwire master and slave.
>>
>> Currently, the channel value for each soundwire port is hardcoded in the
>> wcd937x-sdw driver and the same channel  value is configured in the
>> soundwire master.
>>
>> The Qualcomm board like the QCM6490-IDP require static channel map
>> settings for the soundwire master and slave ports.
>>
>> If another boards which are using enable wcd937x, the channel mapping
>> index values between master and slave may be different depending on the
>> board hw design and requirements. If the above properties are not used
>> in a SoC specific device tree, the channel mapping index values are set
>> to default.
>>
>> With the introduction of the following channel mapping properties, it is
>> now possible to configure the master channel mapping directly from the
>> device tree.
>>
>> Added qcom_swrm_set_channel_map api to set the master channel values
>> which allows more flexible to configure channel values in runtime for
>> specific active soundwire ports.
>>
>> Add get and set channel maps support from codec to cpu dais in common
>> Qualcomm sdw driver.
>>
>> Changes since v5:
>>   - Fixed build compile issue with v5-0003 patch, reported by Mark Brown.
>>
>> Changes since v4:
>>   - Update the order of channel map index values in v4-0001 dt- 
>> bindings patch as suggested by Krzysztof.
>> Changes since v3:
>>   - Change the order of channel map index values in v3-0002 dt- 
>> bindings patch as suggested by Krzysztof.
>>   - Dropped V3-0001 patch which is not required.
>>
>> Changes since v2:
>>   - Rephrase commit description v2-0001 dt-bindings patch as suggested 
>> by Krzysztof.
>>
>> Changes since v1:
>>   - Modified the design and followed new approach to setting the 
>> master channel mask.
>>   - Used existing set_channel_map api as suggested by Pierre-Louis
>>   - Fixed the typo mistake in v1-0001 dt-bindings patch.
>>   - Rephrase the commit description for all v1 patches.
>>
>> Mohammad Rafi Shaik (4):
>>    ASoC: dt-bindings: wcd937x-sdw: Add static channel mapping support
>>    ASoC: codecs: wcd937x: Add static channel mapping support in
>>      wcd937x-sdw
>>    soundwire: qcom: Add set_channel_map api support
>>    ASoC: qcom: sdw: Add get and set channel maps support from codec to
>>      cpu dais
>>
>>   .../bindings/sound/qcom,wcd937x-sdw.yaml      | 36 +++++++++++++
>>   drivers/soundwire/qcom.c                      | 26 +++++++++
>>   sound/soc/codecs/wcd937x-sdw.c                | 39 ++++++++++++--
>>   sound/soc/codecs/wcd937x.c                    | 53 ++++++++++++++++++-
>>   sound/soc/codecs/wcd937x.h                    |  7 ++-
>>   sound/soc/qcom/sdw.c                          | 34 ++++++++++--
>>   6 files changed, 185 insertions(+), 10 deletions(-)
> 
> Hi Mohammad,
> 
> I'm working on a QCS6490 board with the WCD9380 codec. I wonder if a 
> similar patch is needed to enable headset audio? Currently, DisplayPort 
> audio and headset plug-in detection work, but no audio is coming from 
> the headset.
> 
> Additionally, I noticed an unusual output in dmesg:
> 
> qcom-soundwire 3210000.soundwire: qcom_swrm_irq_handler: SWR Port 
> collision detected
> 
> Could this be related to the issue? Let me know if you need further 
> details.
> 

Well, headset audio works now. It seems that the error message has 
nothing to do with it :)

-- 
Best regards,
Xilin Wu <sophon@...xa.com>