linux-kernel - Re: [PATCH net] net: dsa: mt7530: sync driver-specific behavior of MT7531 variants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <F9390C07-3C4F-47FD-A89F-FB5A90D38A84@arinc9.com>
Date: Wed, 23 Apr 2025 06:50:19 +0000 (UTC)
From: "Chester A. Unal" <chester.a.unal@...nc9.com>
To: Daniel Golle <daniel@...rotopia.org>, DENG Qingfang <dqfext@...il.com>,
 Neal Yen <neal.yen@...iatek.com>, Sean Wang <sean.wang@...iatek.com>,
 Andrew Lunn <andrew@...n.ch>, Vladimir Oltean <olteanv@...il.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH net] net: dsa: mt7530: sync driver-specific behavior of MT7531 variants

On 22 April 2025 06:10:20 GMT+03:00, Daniel Golle <daniel@...rotopia.org> wrote:
>MT7531 standalone and MMIO variants found in MT7988 and EN7581 share
>most basic properties. Despite that, assisted_learning_on_cpu_port and
>mtu_enforcement_ingress were only applied for MT7531 but not for MT7988
>or EN7581, causing the expected issues on MMIO devices.
>
>Apply both settings equally also for MT7988 and EN7581 by moving both
>assignments form mt7531_setup() to mt7531_setup_common().
>
>This fixes unwanted flooding of packets due to unknown unicast
>during DA lookup, as well as issues with heterogenous MTU settings.
>
>Fixes: 7f54cc9772ce ("net: dsa: mt7530: split-off common parts from mt7531_setup")
>Signed-off-by: Daniel Golle <daniel@...rotopia.org>
>---
>See also https://git01.mediatek.com/plugins/gitiles/openwrt/feeds/mtk-openwrt-feeds/+/b4204fb062d60ac57791c90a11d05cf75269dcbd

Reviewed-by: Chester A. Unal <chester.a.unal@...nc9.com>

Chester A.