linux-kernel - Re: [PATCH 2/3 V1] lib: logic_pio: export function symbol in logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0c71d318-a7d8-4b40-8721-fa21a7fa806a@oracle.com>
Date: Wed, 23 Apr 2025 08:18:17 +0100
From: John Garry <john.g.garry@...cle.com>
To: Pei Xiao <xiaopei01@...inos.cn>, xiaopeitux@...mail.com
Cc: andriy.shevchenko@...ux.intel.com, linux-kernel@...r.kernel.org,
        robh@...nel.org, xuwei5@...ilicon.com
Subject: Re: [PATCH 2/3 V1] lib: logic_pio: export function symbol in
 logic_pio

On 23/04/2025 04:36, Pei Xiao wrote:
> 
> 在 2025/4/23 00:05, John Garry 写道:
>> On 22/04/2025 12:31, xiaopeitux@...mail.com wrote:
>>> From: Pei Xiao<xiaopei01@...inos.cn>
>>>
>>> export some function via EXPORT_SYMBOL, convenient to use in
>>> kernel modules in the future if somebody went to use this lib.
>>> This is one reason for this library exists.
>>>
>>> Signed-off-by: Pei Xiao<xiaopei01@...inos.cn>
>>
>> No, we don't export just because someone might need this is future.
>>
> Now modify it，Might it be convenient for future people?
> 
> People in the future might be able to save some effort here.

No, absolutely not. The reason we don't is because it enables more 
out-of-tree rubbish.

> 
>> And, FWIW, EXPORT_SYMBOL_GPL is preferred.