[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
<PH0PR03MB71410C963D66BDEE7F5062BFF9BA2@PH0PR03MB7141.namprd03.prod.outlook.com>
Date: Wed, 23 Apr 2025 07:50:14 +0000
From: "Paller, Kim Seer" <KimSeer.Paller@...log.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
CC: Conor Dooley <conor+dt@...nel.org>,
"linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>,
Andy Shevchenko <andy@...nel.org>,
Lars-Peter
Clausen <lars@...afoo.de>,
Nuno Sá
<noname.nuno@...il.com>,
"Sa, Nuno" <Nuno.Sa@...log.com>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
Krzysztof
Kozlowski <krzk+dt@...nel.org>,
"Hennerich, Michael"
<Michael.Hennerich@...log.com>,
"linux-iio@...r.kernel.org"
<linux-iio@...r.kernel.org>,
Jonathan Cameron <jic23@...nel.org>,
Krzysztof
Kozlowski <krzysztof.kozlowski@...aro.org>,
David Lechner
<dlechner@...libre.com>
Subject: RE: [PATCH v5 2/3] dt-bindings: iio: dac: Add adi,ad3530r.yaml
> -----Original Message-----
> From: Rob Herring (Arm) <robh@...nel.org>
> Sent: Monday, April 21, 2025 1:29 PM
> To: Paller, Kim Seer <KimSeer.Paller@...log.com>
> Cc: Conor Dooley <conor+dt@...nel.org>; linux-kernel@...r.kernel.org; Andy
> Shevchenko <andy@...nel.org>; Lars-Peter Clausen <lars@...afoo.de>; Nuno
> Sá <noname.nuno@...il.com>; Sa, Nuno <Nuno.Sa@...log.com>;
> devicetree@...r.kernel.org; Krzysztof Kozlowski <krzk+dt@...nel.org>;
> Hennerich, Michael <Michael.Hennerich@...log.com>; linux-
> iio@...r.kernel.org; Jonathan Cameron <jic23@...nel.org>; Krzysztof
> Kozlowski <krzysztof.kozlowski@...aro.org>; David Lechner
> <dlechner@...libre.com>
> Subject: Re: [PATCH v5 2/3] dt-bindings: iio: dac: Add adi,ad3530r.yaml
>
> [External]
>
>
> On Mon, 21 Apr 2025 12:24:53 +0800, Kim Seer Paller wrote:
> > Document the AD3530/AD3530R (8-channel) and AD3531/AD3531R (4-
> channel)
> > low-power, 16-bit, buffered voltage output DACs with software-
> > programmable gain controls. They provide full-scale output spans of
> > 2.5V or 5V for reference voltages of 2.5V. These devices operate on a
> > single 2.7V to 5.5V supply and are guaranteed to be monotonic by design.
> > The "R" variants include a 2.5V, 5ppm/°C internal reference, which is
> > disabled by default.
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> > Reviewed-by: David Lechner <dlechner@...libre.com>
> > Signed-off-by: Kim Seer Paller <kimseer.paller@...log.com>
> > ---
> > .../devicetree/bindings/iio/dac/adi,ad3530r.yaml | 100
> +++++++++++++++++++++
> > MAINTAINERS | 7 ++
> > 2 files changed, 107 insertions(+)
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/soc/fsl/fsl,ls1028a-reset.yaml:
> maintainers:0: 'Frank Li' does not match '@'
> from schema $id:
> https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/base.yaml*__;Iw!!A3Ni8CS0y2Y!5_8LSBMQDGzDudUoqQnNMjX7xJUq
> nraYNchQ_A3pjbCPArrjLG-DhM4Ycsv0lSZN4dOkjYmd6_lIvBib$
This error is not related to the ad3530r DT bindings.
>
> doc reference errors (make refcheckdocs):
> Documentation/userspace-api/netlink/netlink-raw.rst:
> :doc:`rt_link<../../networking/netlink_spec/rt_link>`
> Warning: MAINTAINERS references a file that doesn't exist:
> Documentation/devicetree/bindings/leds/backlight/ti,lp8864.yaml
> Documentation/userspace-api/netlink/netlink-raw.rst:
> :doc:`rt_link<../../networking/netlink_spec/rt_link>`
> MAINTAINERS:
> Documentation/devicetree/bindings/leds/backlight/ti,lp8864.yaml
>
> See
> https://urldefense.com/v3/__https://patchwork.ozlabs.org/project/devicetree-
> bindings/patch/20250421-togreg-v5-2-
> 94341574240f@...log.com__;!!A3Ni8CS0y2Y!5_8LSBMQDGzDudUoqQnNMjX
> 7xJUqnraYNchQ_A3pjbCPArrjLG-DhM4Ycsv0lSZN4dOkjYmd60Ff7zKu$
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above error(s),
> then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
Powered by blists - more mailing lists