linux-kernel - Re: [PATCH v4 04/12] kernel: ftrace: export ftrace_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f65d7be-37d2-4646-bfb0-34b78047d4db@ghiti.fr>
Date: Wed, 23 Apr 2025 10:13:32 +0200
From: Alexandre Ghiti <alex@...ti.fr>
To: kernel test robot <lkp@...el.com>, Andy Chiu <andybnac@...il.com>,
 linux-riscv@...ts.infradead.org, alexghiti@...osinc.com, palmer@...belt.com
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org, Mark Rutland <mark.rutland@....com>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, bjorn@...osinc.com,
 puranjay12@...il.com, paul.walmsley@...ive.com, greentime.hu@...ive.com,
 nick.hu@...ive.com, nylon.chen@...ive.com, eric.lin@...ive.com,
 vicent.chen@...ive.com, zong.li@...ive.com, yongxuan.wang@...ive.com,
 samuel.holland@...ive.com, olivia.chu@...ive.com, c2232430@...il.com
Subject: Re: [PATCH v4 04/12] kernel: ftrace: export ftrace_sync_ipi

Hi Andy,

On 09/04/2025 00:31, kernel test robot wrote:
> Hi Andy,
>
> kernel test robot noticed the following build warnings:
>
> [auto build test WARNING on linus/master]
> [also build test WARNING on v6.15-rc1 next-20250408]
> [cannot apply to trace/for-next]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Andy-Chiu/riscv-ftrace-factor-out-code-defined-by-WITH_ARG/20250408-025114
> base:   linus/master
> patch link:    https://lore.kernel.org/r/20250407180838.42877-4-andybnac%40gmail.com
> patch subject: [PATCH v4 04/12] kernel: ftrace: export ftrace_sync_ipi
> config: xtensa-randconfig-001-20250409 (https://download.01.org/0day-ci/archive/20250409/202504090657.5fiH4UIS-lkp@intel.com/config)
> compiler: xtensa-linux-gcc (GCC) 11.5.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250409/202504090657.5fiH4UIS-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202504090657.5fiH4UIS-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
>>> kernel/trace/ftrace.c:191:6: warning: no previous prototype for 'ftrace_sync_ipi' [-Wmissing-prototypes]
>       191 | void ftrace_sync_ipi(void *data)
>           |      ^~~~~~~~~~~~~~~
>
>
> vim +/ftrace_sync_ipi +191 kernel/trace/ftrace.c
>
>     190	
>   > 191	void ftrace_sync_ipi(void *data)
>     192	{
>     193		/* Probably not needed, but do it anyway */
>     194		smp_rmb();
>     195	}
>     196	
>

I fixed this with the following that I squashed into your patch, no need 
to resend a new series for this.

diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h
index 0d4eec5747074..30374478cb077 100644
--- a/include/linux/ftrace.h
+++ b/include/linux/ftrace.h
@@ -635,6 +635,8 @@ enum {
  #define ftrace_get_symaddr(fentry_ip) (0)
  #endif

+void ftrace_sync_ipi(void *data);
+
  #ifdef CONFIG_DYNAMIC_FTRACE

  void ftrace_arch_code_modify_prepare(void);
@@ -807,7 +809,6 @@ extern void ftrace_call(void);
  extern void ftrace_regs_call(void);
  extern void mcount_call(void);

-void ftrace_sync_ipi(void *data);
  void ftrace_modify_all_code(int command);

  #ifndef FTRACE_ADDR


Thanks,

Alex