linux-kernel - Re: [PATCH v8 05/15] xfs: ignore HW which cannot atomic write a single block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f27ea8f7-700a-4fb1-b9cd-a0cba04c9e47@oracle.com>
Date: Wed, 23 Apr 2025 09:28:14 +0100
From: John Garry <john.g.garry@...cle.com>
To: Christoph Hellwig <hch@....de>
Cc: "Darrick J. Wong" <djwong@...nel.org>, brauner@...nel.org,
        viro@...iv.linux.org.uk, jack@...e.cz, cem@...nel.org,
        linux-fsdevel@...r.kernel.org, dchinner@...hat.com,
        linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org,
        ojaswin@...ux.ibm.com, ritesh.list@...il.com,
        martin.petersen@...cle.com, linux-ext4@...r.kernel.org,
        linux-block@...r.kernel.org, catherine.hoang@...cle.com,
        linux-api@...r.kernel.org
Subject: Re: [PATCH v8 05/15] xfs: ignore HW which cannot atomic write a
 single block

On 23/04/2025 09:10, Christoph Hellwig wrote:
> On Wed, Apr 23, 2025 at 08:15:43AM +0100, John Garry wrote:
>> Ideally we could have not set them in the first place, but need to know the
>> blocksize when xfs_alloc_buftarg() is called, but it is not yet set for
>> mp/sb. Is there any neat way to know the blocksize when xfs_alloc_buftarg()
>> is called?
> 
> The buftarg is needed to read the superblock, which is used to determine
> the block size, so no.
> 
> But maybe we should just delay setting the atomic values until later so
> that it can be done in a single pass?  E.g. into xfs_setsize_buftarg
> which then should probably be rename to something like
> xfs_buftarg_setup.
> 

How about just do away with btp->bt_bdev_awu_{min, max} struct members, 
and call bdev_atomic_write_unit_max(mp->m_ddev_targp->bt_bdev) [and same 
for RT] to later to set the mp awu max values at mountfs time? I think 
that would work..