linux-kernel - Re: [PATCH 2/8] net: octeontx2: Use pure PCI devres API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <00189e0a036e1bc7af8f78cc9fa934f1ad23efba.camel@mailbox.org>
Date: Wed, 23 Apr 2025 10:38:01 +0200
From: Philipp Stanner <phasta@...lbox.org>
To: phasta@...nel.org, Jakub Kicinski <kuba@...nel.org>
Cc: Sunil Goutham <sgoutham@...vell.com>, Andrew Lunn
 <andrew+netdev@...n.ch>,  "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Geetha
 sowjanya <gakula@...vell.com>, Subbaraya Sundeep <sbhatta@...vell.com>,
 hariprasad <hkelam@...vell.com>, Bharat Bhushan <bbhushan2@...vell.com>,
 Taras Chornyi <taras.chornyi@...ision.eu>, Daniele Venzano
 <venza@...wnhat.org>, Heiner Kallweit <hkallweit1@...il.com>, Russell King
 <linux@...linux.org.uk>, Thomas Gleixner <tglx@...utronix.de>, Helge Deller
 <deller@....de>, Ingo Molnar <mingo@...nel.org>,  Simon Horman
 <horms@...nel.org>, Al Viro <viro@...iv.linux.org.uk>, Sabrina Dubroca
 <sd@...asysnail.net>,  Jacob Keller <jacob.e.keller@...el.com>,
 linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org, 
 linux-kernel@...r.kernel.org, linux-parisc@...r.kernel.org
Subject: Re: [PATCH 2/8] net: octeontx2: Use pure PCI devres API

On Wed, 2025-04-23 at 08:28 +0200, Philipp Stanner wrote:
> On Tue, 2025-04-22 at 17:49 -0700, Jakub Kicinski wrote:
> > On Wed, 16 Apr 2025 18:44:02 +0200 Philipp Stanner wrote:
> > >  err_release_regions:
> > >  	pci_set_drvdata(pdev, NULL);
> > > -	pci_release_regions(pdev);
> > 
> > This error path should be renamed. Could you also apply your
> > conversion
> > to drivers/net/ethernet/marvell/octeontx2/af/ ?
> 
> Hm, those must have slipped me for some reason. Will reiterate with
> them and the error path.

Wait, false alarm. I actually did look at them and those in af/ don't
seem to use the combination of pcim_enable_device() + pci_request_*

Only users of that combination have to be ported. Users of
pci_enable_device() + pcim_* functions and pcim_enable_device() +
pcim_* functions are fine.

Correct me if I missed the first mentioned combination up there.

P.

> 
> P.
>