linux-kernel - Re: [PATCH] caamalg: Make use of dev_*() instead of pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dbf1577c-220d-4eff-bc1d-649d0d70678c@nxp.com>
Date: Wed, 23 Apr 2025 09:22:02 +0000
From: Horia Geanta <horia.geanta@....com>
To: "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>, Pankaj
 Gupta <pankaj.gupta@....com>, Gaurav Jain <gaurav.jain@....com>, Herbert Xu
	<herbert@...dor.apana.org.au>, "David S. Miller" <davem@...emloft.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] caamalg: Make use of dev_*() instead of pr_*()

On 4/23/2025 10:29 AM, Ben Collins wrote:
> It's nice when messages line up with the device, and easy to implement
> since it's already available in the functions.
> 
> Signed-off-by: Ben Collins <bcollins@...nel.org>
> Cc: "Horia Geantă" <horia.geanta@....com>
> Cc: Pankaj Gupta <pankaj.gupta@....com>
> Cc: Gaurav Jain <gaurav.jain@....com>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: linux-crypto@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> ---
>  drivers/crypto/caam/caamalg.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/crypto/caam/caamalg.c b/drivers/crypto/caam/caamalg.c
> index 2cfb1b8d8c7cf..d964a62ef9668 100644
> --- a/drivers/crypto/caam/caamalg.c
> +++ b/drivers/crypto/caam/caamalg.c
> @@ -3633,7 +3633,7 @@ static int caam_cra_init(struct crypto_skcipher *tfm)
>  		fallback = crypto_alloc_skcipher(tfm_name, 0,
>  						 CRYPTO_ALG_NEED_FALLBACK);
>  		if (IS_ERR(fallback)) {
> -			pr_err("Failed to allocate %s fallback: %ld\n",
> +			dev_err(ctx->jrdev, "Failed to allocate %s fallback: %ld\n",
ctx->jrdev is not initialized at this point;
it's done later in caam_init_common().

Actually, we've fixed the same issue some time ago in commit
ab95bd2aa904 ("crypto: caam - fix printing on xts fallback allocation error path")

Thanks,
Horia