linux-kernel - Re: [PATCH v2 ratelimit 01/14] lib: Add trivial kunit test for ratelimit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aAi0pD9Qt2w5vLpE@pathway.suse.cz>
Date: Wed, 23 Apr 2025 11:36:36 +0200
From: Petr Mladek <pmladek@...e.com>
To: "Paul E. McKenney" <paulmck@...nel.org>
Cc: linux-kernel@...r.kernel.org, kernel-team@...a.com,
	Andrew Morton <akpm@...ux-foundation.org>,
	Kuniyuki Iwashima <kuniyu@...zon.com>,
	Mateusz Guzik <mjguzik@...il.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	John Ogness <john.ogness@...utronix.de>,
	Sergey Senozhatsky <senozhatsky@...omium.org>,
	Jon Pan-Doh <pandoh@...gle.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Karolina Stolarek <karolina.stolarek@...cle.com>
Subject: Re: [PATCH v2 ratelimit 01/14] lib: Add trivial kunit test for
 ratelimit

On Tue 2025-04-22 15:56:11, Paul E. McKenney wrote:
> On Tue, Apr 22, 2025 at 04:44:17PM +0200, Petr Mladek wrote:
> > Hi,
> > 
> > I have been recently involved in a conversion of printf/scanf
> > selftests to KUnit. And I seem that there are some naming
> > conventions. Adding Kees into Cc.
> 
> Thank you for the review and feedback!  Updated patch is
> at the end of this email.
> 
> ------------------------------------------------------------------------
> 
> lib: Add trivial kunit test for ratelimit
> 
> Add a simple single-threaded smoke test for lib/ratelimit.c
> 
> To run on x86:
> 
>         make ARCH=x86_64 mrproper
>         ./tools/testing/kunit/kunit.py run --arch x86_64 --kconfig_add CONFIG_RATELIMIT_KUNIT_TEST=y --kconfig_add CONFIG_SMP=y lib_ratelimit
> 
> This will fail on old ___ratelimit(), and subsequent patches provide
> the fixes that are required.
> 
> [ paulmck:  Apply timeout and kunit feedback from Petr Mladek. ]
> 
> Signed-off-by: Paul E. McKenney <paulmck@...nel.org>
> Reviewed-by: Petr Mladek <pmladek@...e.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Kuniyuki Iwashima <kuniyu@...zon.com>
> Cc: Mateusz Guzik <mjguzik@...il.com>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Cc: John Ogness <john.ogness@...utronix.de>
> Cc: Sergey Senozhatsky <senozhatsky@...omium.org>
> Cc: Jon Pan-Doh <pandoh@...gle.com>
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> Cc: Karolina Stolarek <karolina.stolarek@...cle.com>

JFYI, I have checked this updated version and looks good to me.

Best Regards,
Petr