linux-kernel - Re: [PATCH v3] arm64: dts: imx8mm-verdin: Link reg_usdhc2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aAi_PPaZRF26pv_d@gaggiata.pivistrello.it>
Date: Wed, 23 Apr 2025 12:21:48 +0200
From: Francesco Dolcini <francesco@...cini.it>
To: Philippe Schenker <philippe.schenker@...ulsing.ch>
Cc: Francesco Dolcini <francesco@...cini.it>,
	Wojciech Dubowik <Wojciech.Dubowik@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH v3] arm64: dts: imx8mm-verdin: Link reg_usdhc2_vqmmc to
 usdhc2

On Wed, Apr 23, 2025 at 10:16:43AM +0000, Philippe Schenker wrote:
> 
> 
> On Wed, 2025-04-23 at 11:53 +0200, Francesco Dolcini wrote:
> > On Tue, Apr 22, 2025 at 04:01:57PM +0200, Wojciech Dubowik wrote:
> > > Define vqmmc regulator-gpio for usdhc2 with vin-supply
> > > coming from LDO5.
> > > 
> > > Without this definition LDO5 will be powered down, disabling
> > > SD card after bootup. This has been introduced in commit
> > > f5aab0438ef1 ("regulator: pca9450: Fix enable register for LDO5").
> > > 
> > > Fixes: f5aab0438ef1 ("regulator: pca9450: Fix enable register for
> > > LDO5")
> > > 
> > no empty lines in between commit message tags, not sure if Shawn can
> > fix
> > this up or you need to send a v4.
> > 
> > > Cc: stable@...r.kernel.org
> > > Signed-off-by: Wojciech Dubowik <Wojciech.Dubowik@...com>
> > 
> > Tested-by: Francesco Dolcini <francesco.dolcini@...adex.com>
> > Reviewed-by: Francesco Dolcini <francesco.dolcini@...adex.com>
> > 
> > I would backport this to also older kernel, so to me
> > 
> > Fixes: 6a57f224f734 ("arm64: dts: freescale: add initial support for
> > verdin imx8m mini")
> 
> NACK for the proposed Fixes, this introduces a new Kconfig which could
> have side-effects in users of current stable kernels.

The driver for "regulator-gpio" compatible? I do not agree with your argument,
sorry. 

The previous description was not correct. There was an unused
regulator in the DT that was not switched off just by chance.

Francesco