linux-kernel - Re: [PATCH v4 0/4] virtio-net: disable delayed refill when pausing rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <174537302875.2111809.8543884098526067319.git-patchwork-notify@kernel.org>
Date: Wed, 23 Apr 2025 01:50:28 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Bui Quang Minh <minhquangbui99@...il.com>
Cc: virtualization@...ts.linux.dev, mst@...hat.com, jasowang@...hat.com,
 xuanzhuo@...ux.alibaba.com, andrew+netdev@...n.ch, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, ast@...nel.org, daniel@...earbox.net,
 hawk@...nel.org, john.fastabend@...il.com, eperezma@...hat.com,
 davem@...emloft.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 bpf@...r.kernel.org
Subject: Re: [PATCH v4 0/4] virtio-net: disable delayed refill when pausing rx

Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Thu, 17 Apr 2025 14:28:02 +0700 you wrote:
> Hi everyone,
> 
> This series tries to fix a deadlock in virtio-net when binding/unbinding
> XDP program, XDP socket or resizing the rx queue.
> 
> When pausing rx (e.g. set up xdp, xsk pool, rx resize), we call
> napi_disable() on the receive queue's napi. In delayed refill_work, it
> also calls napi_disable() on the receive queue's napi. When
> napi_disable() is called on an already disabled napi, it will sleep in
> napi_disable_locked while still holding the netdev_lock. As a result,
> later napi_enable gets stuck too as it cannot acquire the netdev_lock.
> This leads to refill_work and the pause-then-resume tx are stuck
> altogether.
> 
> [...]

Here is the summary with links:
  - [v4,1/4] virtio-net: disable delayed refill when pausing rx
    https://git.kernel.org/netdev/net/c/4bc12818b363
  - [v4,2/4] selftests: net: move xdp_helper to net/lib
    (no matching commit)
  - [v4,3/4] selftests: net: add flag to force zerocopy mode in xdp_helper
    (no matching commit)
  - [v4,4/4] selftests: net: add a virtio_net deadlock selftest
    (no matching commit)

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html