linux-kernel - Re: [PATCH net-next v10 3/9] net: devmem: TCP tx netlink api

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2y0vrtd5i.fsf@gmail.com>
Date: Wed, 23 Apr 2025 10:55:53 +0100
From: Donald Hunter <donald.hunter@...il.com>
To: Mina Almasry <almasrymina@...gle.com>
Cc: netdev@...r.kernel.org,  linux-kernel@...r.kernel.org,
  linux-doc@...r.kernel.org,  io-uring@...r.kernel.org,
  virtualization@...ts.linux.dev,  kvm@...r.kernel.org,
  linux-kselftest@...r.kernel.org,  Jakub Kicinski <kuba@...nel.org>,
  "David S. Miller" <davem@...emloft.net>,  Eric Dumazet
 <edumazet@...gle.com>,  Paolo Abeni <pabeni@...hat.com>,  Simon Horman
 <horms@...nel.org>,  Jonathan Corbet <corbet@....net>,  Andrew Lunn
 <andrew+netdev@...n.ch>,  Jeroen de Borst <jeroendb@...gle.com>,
  Harshitha Ramamurthy <hramamurthy@...gle.com>,  Kuniyuki Iwashima
 <kuniyu@...zon.com>,  Willem de Bruijn <willemb@...gle.com>,  Jens Axboe
 <axboe@...nel.dk>,  Pavel Begunkov <asml.silence@...il.com>,  David Ahern
 <dsahern@...nel.org>,  Neal Cardwell <ncardwell@...gle.com>,  Stefan
 Hajnoczi <stefanha@...hat.com>,  Stefano Garzarella <sgarzare@...hat.com>,
  "Michael S. Tsirkin" <mst@...hat.com>,  Jason Wang <jasowang@...hat.com>,
  Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,  Eugenio Pérez
 <eperezma@...hat.com>,  Shuah Khan <shuah@...nel.org>,  sdf@...ichev.me,
  dw@...idwei.uk,  Jamal Hadi Salim <jhs@...atatu.com>,  Victor Nogueira
 <victor@...atatu.com>,  Pedro Tammela <pctammela@...atatu.com>,  Samiullah
 Khawaja <skhawaja@...gle.com>
Subject: Re: [PATCH net-next v10 3/9] net: devmem: TCP tx netlink api

Mina Almasry <almasrymina@...gle.com> writes:

> From: Stanislav Fomichev <sdf@...ichev.me>
>
> Add bind-tx netlink call to attach dmabuf for TX; queue is not
> required, only ifindex and dmabuf fd for attachment.
>
> Signed-off-by: Stanislav Fomichev <sdf@...ichev.me>
> Signed-off-by: Mina Almasry <almasrymina@...gle.com>
>
> ---
>
> v3:
> - Fix ynl-regen.sh error (Simon).
>
> ---
>  Documentation/netlink/specs/netdev.yaml | 12 ++++++++++++
>  include/uapi/linux/netdev.h             |  1 +
>  net/core/netdev-genl-gen.c              | 13 +++++++++++++
>  net/core/netdev-genl-gen.h              |  1 +
>  net/core/netdev-genl.c                  |  6 ++++++
>  tools/include/uapi/linux/netdev.h       |  1 +
>  6 files changed, 34 insertions(+)
>
> diff --git a/Documentation/netlink/specs/netdev.yaml b/Documentation/netlink/specs/netdev.yaml
> index f5e0750ab71db..c0ef6d0d77865 100644
> --- a/Documentation/netlink/specs/netdev.yaml
> +++ b/Documentation/netlink/specs/netdev.yaml
> @@ -743,6 +743,18 @@ operations:
>              - defer-hard-irqs
>              - gro-flush-timeout
>              - irq-suspend-timeout
> +    -
> +      name: bind-tx
> +      doc: Bind dmabuf to netdev for TX

nit: maybe add "for RX" to the bind-rx doc.

> +      attribute-set: dmabuf

The bind-rx op has "flags: [ admin-perm ]", should bind-tx also?

> +      do:
> +        request:
> +          attributes:
> +            - ifindex
> +            - fd
> +        reply:
> +          attributes:
> +            - id