linux-kernel - Re: [PATCH] spi: spi-qpic-snand: propagate errors from qcom_spi_block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c860a06-48ff-554b-824b-51fdf4d51f4e@quicinc.com>
Date: Thu, 24 Apr 2025 17:01:25 +0530
From: Md Sadre Alam <quic_mdalam@...cinc.com>
To: Gabor Juhos <j4g8y7@...il.com>, Mark Brown <broonie@...nel.org>,
        "Sricharan Ramabadhran" <quic_srichara@...cinc.com>,
        Varadarajan Narayanan
	<quic_varada@...cinc.com>
CC: <linux-spi@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] spi: spi-qpic-snand: propagate errors from
 qcom_spi_block_erase()



On 4/24/2025 1:01 AM, Gabor Juhos wrote:
> The qcom_spi_block_erase() function returns with error in case of
> failure. Change the qcom_spi_send_cmdaddr() function to propagate
> these errors to the callers instead of returning with success.
> 
> Fixes: 7304d1909080 ("spi: spi-qpic: add driver for QCOM SPI NAND flash Interface")
> Signed-off-by: Gabor Juhos <j4g8y7@...il.com>
> ---
>   drivers/spi/spi-qpic-snand.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-qpic-snand.c b/drivers/spi/spi-qpic-snand.c
> index 17eb67e19132612c4c1a84848fa6f7432b1130a8..ae32c452d0bcf852b69b76e595f3588ea7e1a670 100644
> --- a/drivers/spi/spi-qpic-snand.c
> +++ b/drivers/spi/spi-qpic-snand.c
> @@ -1307,8 +1307,7 @@ static int qcom_spi_send_cmdaddr(struct qcom_nand_controller *snandc,
>   		snandc->qspi->addr1 = cpu_to_le32(s_op.addr1_reg << 16);
>   		snandc->qspi->addr2 = cpu_to_le32(s_op.addr2_reg);
>   		snandc->qspi->cmd = cpu_to_le32(cmd);
> -		qcom_spi_block_erase(snandc);
> -		return 0;
> +		return qcom_spi_block_erase(snandc);
>   	default:
>   		break;
>   	}
> 
> ---
> base-commit: 9c32cda43eb78f78c73aee4aa344b777714e259b
> change-id: 20250422-qpic-snand-propagate-error-9c95811ab811

Reviewed-by: Md Sadre Alam <quic_mdalam@...cinc.com>

> Best regards,