linux-kernel - Re: [PATCH] btrfs: unlock all extent buffer folios in failure case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250424115757.GM3659@suse.cz>
Date: Thu, 24 Apr 2025 13:57:57 +0200
From: David Sterba <dsterba@...e.cz>
To: Klara Modin <klarasmodin@...il.com>
Cc: Daniel Vacek <neelx@...e.com>, Chris Mason <clm@...com>,
	Josef Bacik <josef@...icpanda.com>, David Sterba <dsterba@...e.com>,
	linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] btrfs: unlock all extent buffer folios in failure case

On Thu, Apr 24, 2025 at 01:15:24PM +0200, Klara Modin wrote:
> 
> Hi,
> 
> On Tue, Apr 22, 2025 at 02:57:01PM +0200, Daniel Vacek wrote:
> > When attaching a folio fails, for example if another one is already mapped,
> > we need to unlock all newly allocated folios before putting them. And as a
> > consequence we do not need to flag the eb UNMAPPED anymore.
> > 
> > Signed-off-by: Daniel Vacek <neelx@...e.com>
> 
> I hit a null pointer dereference in next-20250424 which seems to point
> to this commit. Reverting it resolves the issue for me (did not bisect).

Thanks for the report, the patch has been removed from linux-next
branches.