linux-kernel - Re: [PATCH net-next] rxrpc: rxgk: Fix some reference count leaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3113808.1745497595@warthog.procyon.org.uk>
Date: Thu, 24 Apr 2025 13:26:35 +0100
From: David Howells <dhowells@...hat.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: dhowells@...hat.com, Marc Dionne <marc.dionne@...istor.com>,
    "David S. Miller" <davem@...emloft.net>,
    Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
    Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
    linux-afs@...ts.infradead.org, netdev@...r.kernel.org,
    linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] rxrpc: rxgk: Fix some reference count leaks

Dan Carpenter <dan.carpenter@...aro.org> wrote:

> These paths should call rxgk_put(gk) but they don't.  In the
> rxgk_construct_response() function the "goto error;" will free the
> "response" skb as well calling rxgk_put() so that's a bonus.
> 
> Fixes: 9d1d2b59341f ("rxrpc: rxgk: Implement the yfs-rxgk security class (GSSAPI)")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Acked-by: David Howells <dhowells@...hat.com>