linux-kernel - Re: [PATCH rc] iommu: Skip PASID validation for devices without PASID capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250424123156.GO1648741@nvidia.com>
Date: Thu, 24 Apr 2025 09:31:56 -0300
From: Jason Gunthorpe <jgg@...dia.com>
To: Vasant Hegde <vasant.hegde@....com>
Cc: Baolu Lu <baolu.lu@...ux.intel.com>, Tushar Dave <tdave@...dia.com>,
	joro@...tes.org, will@...nel.org, robin.murphy@....com,
	kevin.tian@...el.com, yi.l.liu@...el.com, iommu@...ts.linux.dev,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH rc] iommu: Skip PASID validation for devices without
 PASID capability

On Thu, Apr 24, 2025 at 12:08:56PM +0530, Vasant Hegde wrote:

> > What the iommu driver should do when set_dev_pasid is called for a non-
> > PASID device?

That's a good point, maybe the core code should filter that out based
on max_pasids? I think we do run into trouble here because the drivers
are allocating PASID table space based on max_pasids so the non-pasid
device should fail to add the pasid. Tushar, you should have hit this
in your testing???

We also have a problem setting up the default domain - it won't
compute IOMMU_HWPT_ALLOC_PASID properly across the group. If the
no-pasid device probes first then PASID will be broken on the group.

Tushar isn't hitting this because ARM always uses a PASID compatible
domain today, but it will not work on AMD.

That's a huge pain to deal with :\

> Per device max_pasids check should cover that right?

The driver shouldn't be doing this though, if the driver is told to
make a pasid then it should make a pasid.. The driver can fail
attaching a pasid to a device that is over the device's max_pasid.

> FYI. One example of such device is some of the AMD GPUs which has
> both VGA and audio in same group. while VGA supports PASID, audio is
> not. This used to work fine when we had AMD IOMMU PASID specific
> driver. GPUs stopped using PASIDs in upstream kernel. So I didn't
> look into this part in details.

Uhhh.. That sounds like a worse problem, the only way you should end
up with same group is if the ACS flags are missing on the GPU so Linux
assumes the VGA and audio can loopback to each other internally.

That should completely block PASID support on the GPU side due the
wrong routing. We can't have a hole in the PASID address space where
the audio BAR is.

I suppose the HW doesn't actually behave this way but since it doesn't
have the right ACS flags the SW doesn't know? Guessing..

Jason