linux-kernel - Re: [PATCH v3 0/3] Apple PMIC NVMEM cell driver (Formerly: Generic SPMI NVMEM cell driver)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEg-Je-n+=dHzt3b5oDCk3uYm6vBpsFzy-47sDeJB_=rs7OR3A@mail.gmail.com>
Date: Wed, 23 Apr 2025 22:12:54 -0400
From: Neal Gompa <neal@...pa.dev>
To: fnkl.kernel@...il.com
Cc: Sven Peter <sven@...npeter.dev>, Janne Grunau <j@...nau.net>, 
	Alyssa Rosenzweig <alyssa@...enzweig.io>, Srinivas Kandagatla <srinivas.kandagatla@...aro.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	asahi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Hector Martin <marcan@...can.st>, Nick Chan <towinchenmi@...il.com>
Subject: Re: [PATCH v3 0/3] Apple PMIC NVMEM cell driver (Formerly: Generic
 SPMI NVMEM cell driver)

On Wed, Apr 23, 2025 at 1:55 PM Sasha Finkelstein via B4 Relay
<devnull+fnkl.kernel.gmail.com@...nel.org> wrote:
>
> Hi.
>
> This patch series adds a driver for exposing a set of registers
> as NVMEM cells on a SPMI-attached PMIC on Apple ARM platforms.
> Those are used to store the RTC offset and to communicate platform
> power state between the OS and boot firmware.
>
> The NVMEM cell consumer drivers will be sent in a further series.
>
> Signed-off-by: Sasha Finkelstein <fnkl.kernel@...il.com>
> ---
> Changes in v3:
> - No longer try to make it generic, use for the 3 relevant PMICs only
> - Link to v2: https://lore.kernel.org/r/20250417-spmi-nvmem-v2-0-b88851e34afb@gmail.com
>
> Changes in v2:
> - s/pmu/pmic/
> - Sort dts in unit-order, instead of t600x-unit-order
> - Link to v1: https://lore.kernel.org/r/20250415-spmi-nvmem-v1-0-22067be253cf@gmail.com
>
> ---
> Hector Martin (2):
>       nvmem: Add apple-spmi-nvmem driver
>       arm64: dts: apple: Add PMIC NVMEM
>
> Sasha Finkelstein (1):
>       dt-bindings: spmi: Add Apple SPMI NVMEM
>
>  .../bindings/nvmem/apple,spmi-nvmem.yaml           | 54 +++++++++++++++++++
>  MAINTAINERS                                        |  2 +
>  arch/arm64/boot/dts/apple/t6001.dtsi               |  1 +
>  arch/arm64/boot/dts/apple/t6002.dtsi               |  1 +
>  arch/arm64/boot/dts/apple/t600x-die0.dtsi          | 50 +++++++++++++++++
>  arch/arm64/boot/dts/apple/t8103.dtsi               | 50 +++++++++++++++++
>  arch/arm64/boot/dts/apple/t8112.dtsi               | 50 +++++++++++++++++
>  drivers/nvmem/Kconfig                              | 13 +++++
>  drivers/nvmem/Makefile                             |  2 +
>  drivers/nvmem/apple-spmi-nvmem.c                   | 62 ++++++++++++++++++++++
>  10 files changed, 285 insertions(+)
> ---
> base-commit: 2e0e70c95077172b29a5b13716c4b159d578e82c
> change-id: 20250415-spmi-nvmem-e08635316175
>

Series LGTM.

Reviewed-by: Neal Gompa <neal@...pa.dev>


-- 
真実はいつも一つ！/ Always, there's only one truth!