linux-kernel - 答复: [PATCH] net: Move specific fragmented packet to slow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <313bbfd54e6540e58e60dfcd9f0e8b2e@exch03.asrmicro.com>
Date: Thu, 24 Apr 2025 02:12:02 +0000
From: Yang Huajian（杨华健） <huajianyang@...micro.com>
To: "pablo@...filter.org" <pablo@...filter.org>
CC: Florian Westphal <fw@...len.de>,
        "kadlec@...filter.org"
	<kadlec@...filter.org>,
        "razor@...ckwall.org" <razor@...ckwall.org>,
        "idosch@...dia.com" <idosch@...dia.com>,
        "davem@...emloft.net"
	<davem@...emloft.net>,
        "dsahern@...nel.org" <dsahern@...nel.org>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org"
	<kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "horms@...nel.org" <horms@...nel.org>,
        "netfilter-devel@...r.kernel.org"
	<netfilter-devel@...r.kernel.org>,
        "coreteam@...filter.org"
	<coreteam@...filter.org>,
        "bridge@...ts.linux.dev" <bridge@...ts.linux.dev>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: 答复: [PATCH] net: Move specific fragmented packet to slow_path instead of dropping it

Hi Pablo,

Can you give some advice?

Thanks.

Best Regards,
Huajian

-----邮件原件-----
发件人: Florian Westphal [mailto:fw@...len.de] 
发送时间: 2025年4月17日 22:12
收件人: Yang Huajian（杨华健） <huajianyang@...micro.com>
抄送: pablo@...filter.org; kadlec@...filter.org; razor@...ckwall.org; idosch@...dia.com; davem@...emloft.net; dsahern@...nel.org; edumazet@...gle.com; kuba@...nel.org; pabeni@...hat.com; horms@...nel.org; netfilter-devel@...r.kernel.org; coreteam@...filter.org; bridge@...ts.linux.dev; netdev@...r.kernel.org; linux-kernel@...r.kernel.org
主题: Re: [PATCH] net: Move specific fragmented packet to slow_path instead of dropping it

Huajian Yang <huajianyang@...micro.com> wrote:
> The config NF_CONNTRACK_BRIDGE will change the bridge forwarding for 
> fragmented packets.
> 
> The original bridge does not know that it is a fragmented packet and 
> forwards it directly, after NF_CONNTRACK_BRIDGE is enabled, function 
> nf_br_ip_fragment and br_ip6_fragment will check the headroom.
> 
> In original br_forward, insufficient headroom of skb may indeed exist, 
> but there's still a way to save the skb in the device driver after 
> dev_queue_xmit.So droping the skb will change the original bridge 
> forwarding in some cases.

Fixes: 3c171f496ef5 ("netfilter: bridge: add connection tracking system")
Reviewed-by: Florian Westphal <fw@...len.de>

This should probably be routed via Pablo.

Pablo, feel free to route this via nf-next if you think its not an urgent fix, its been like this since bridge conntrack was added.