linux-kernel - Re: [PATCH iwl-next 04/16] libeth: xdp: add .ndo_xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aAo3aY3exP3XUNgu@boxer>
Date: Thu, 24 Apr 2025 15:06:49 +0200
From: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
To: Alexander Lobakin <aleksander.lobakin@...el.com>
CC: <intel-wired-lan@...ts.osuosl.org>, Michal Kubiak
	<michal.kubiak@...el.com>, Tony Nguyen <anthony.l.nguyen@...el.com>, "Przemek
 Kitszel" <przemyslaw.kitszel@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "Alexei
 Starovoitov" <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>,
	"Jesper Dangaard Brouer" <hawk@...nel.org>, John Fastabend
	<john.fastabend@...il.com>, Simon Horman <horms@...nel.org>,
	<bpf@...r.kernel.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH iwl-next 04/16] libeth: xdp: add .ndo_xdp_xmit() helpers

On Tue, Apr 15, 2025 at 07:28:13PM +0200, Alexander Lobakin wrote:
> Add helpers for implementing .ndo_xdp_xmit().
> Same as for XDP_TX, accumulate up to 16 DMA-mapped frames on the stack,
> then flush. If DMA mapping is failed for some reason, don't try mapping
> further frames, but still flush what was already prepared.
> DMA address of a head frame is stored in its headroom, assuming it
> has enough of it for an 8 (or 4) byte value.
> In addition to @prep and @xmit driver callbacks in XDP_TX, xmit also
> needs @finalize to kick the XDPSQ after filling.
> 
> Signed-off-by: Alexander Lobakin <aleksander.lobakin@...el.com>

Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>