linux-kernel - Re: [PATCH net-next v1 4/4] net: phy: Always read EEE LPA in genphy_c45_ethtool_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aAo5keWOAVWxj9_o@shell.armlinux.org.uk>
Date: Thu, 24 Apr 2025 14:16:01 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Woojung Huh <woojung.huh@...rochip.com>, Andrew Lunn <andrew@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Heiner Kallweit <hkallweit1@...il.com>, kernel@...gutronix.de,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	UNGLinuxDriver@...rochip.com, Simon Horman <horms@...nel.org>,
	Maxime Chevallier <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH net-next v1 4/4] net: phy: Always read EEE LPA in
 genphy_c45_ethtool_get_eee()

On Thu, Apr 24, 2025 at 03:02:22PM +0200, Oleksij Rempel wrote:
> Previously, genphy_c45_ethtool_get_eee() used genphy_c45_eee_is_active(),
> which skips reading the EEE LPA register if local EEE is disabled. This
> prevents ethtool from reporting the link partner's EEE capabilities in
> that case.
> 
> Replace it with genphy_c45_read_eee_lpa(), which always reads the LPA
> register regardless of local EEE state. This allows users to see the
> link partner's EEE advertisement even when EEE is disabled locally.
> 
> Example before the patch:
> 
>   EEE settings for lan1:
>           EEE status: disabled
>           Tx LPI: disabled
>           Supported EEE link modes:  100baseT/Full
>                                      1000baseT/Full
>           Advertised EEE link modes:  Not reported
>           Link partner advertised EEE link modes:  Not reported
> 
> After the patch:
> 
>   EEE settings for lan1:
>           EEE status: disabled
>           Tx LPI: disabled
>           Supported EEE link modes:  100baseT/Full
>                                      1000baseT/Full
>           Advertised EEE link modes:  Not reported
>           Link partner advertised EEE link modes:  100baseT/Full
>                                                    1000baseT/Full

Seems to me this takes the opposite view to patch 3... not sure there's
much consistency here.

However, I've no objection to reading the LPA EEE state and
reporting it.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!