linux-kernel - Re: [PATCH v2] drm/amdgpu: check a user-provided number of BOs in list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CADnq5_O-tqQ4y7sNx0nMD_0aTFO0H7_vVg=umaPXUbBLFmwnJg@mail.gmail.com>
Date: Thu, 24 Apr 2025 09:40:39 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: Christian König <christian.koenig@....com>
Cc: "Deucher, Alexander" <Alexander.Deucher@....com>, Denis Arefev <arefev@...mel.ru>, 
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	Andrey Grodzovsky <andrey.grodzovsky@....com>, Chunming Zhou <david1.zhou@....com>, 
	"amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>, 
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"lvc-project@...uxtesting.org" <lvc-project@...uxtesting.org>, 
	"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH v2] drm/amdgpu: check a user-provided number of BOs in list

On Wed, Apr 23, 2025 at 10:29 AM Christian König
<christian.koenig@....com> wrote:
>
> On 4/22/25 18:26, Deucher, Alexander wrote:
> > [Public]
> >
> >> -----Original Message-----
> >> From: Alex Deucher <alexdeucher@...il.com>
> >> Sent: Tuesday, April 22, 2025 9:46 AM
> >> To: Koenig, Christian <Christian.Koenig@....com>
> >> Cc: Denis Arefev <arefev@...mel.ru>; Deucher, Alexander
> >> <Alexander.Deucher@....com>; David Airlie <airlied@...il.com>; Simona Vetter
> >> <simona@...ll.ch>; Andrey Grodzovsky <andrey.grodzovsky@....com>;
> >> Chunming Zhou <david1.zhou@....com>; amd-gfx@...ts.freedesktop.org; dri-
> >> devel@...ts.freedesktop.org; linux-kernel@...r.kernel.org; lvc-
> >> project@...uxtesting.org; stable@...r.kernel.org
> >> Subject: Re: [PATCH v2] drm/amdgpu: check a user-provided number of BOs in list
> >>
> >> Applied.  Thanks!
> >
> > This change beaks the following IGT tests:
> >
> > igt@...gpu/amd_vcn@...-decoder-create-decode-destroy@...-decoder-create
> > igt@...gpu/amd_vcn@...-decoder-create-decode-destroy@...-decoder-decode
> > igt@...gpu/amd_vcn@...-decoder-create-decode-destroy@...-decoder-destroy
> > igt@...gpu/amd_jpeg_dec@...gpu_cs_jpeg_decode
> > igt@...gpu/amd_cs_nop@...nops-with-nop-compute0@...nop-with-nop-compute0
> > igt@...gpu/amd_cs_nop@...nops-with-sync-compute0@...nop-with-sync-compute0
> > igt@...gpu/amd_cs_nop@...nops-with-fork-compute0@...nop-with-fork-compute0
> > igt@...gpu/amd_cs_nop@...nops-with-sync-fork-compute0@...nop-with-sync-fork-compute0
> > igt@...gpu/amd_basic@...rptr-with-ip-dma@...rptr
> > igt@...gpu/amd_basic@...compute-with-ip-compute@...compute
> > igt@...gpu/amd_basic@...sdma-with-ip-dma@...sdma
> > igt@...gpu/amd_basic@...ction-test-with-ip-dma@...ction_test
> > igt@...gpu/amd_cp_dma_misc@..._to_vram-amdgpu_hw_ip_compute0
> > igt@...gpu/amd_cp_dma_misc@...m_to_gtt-amdgpu_hw_ip_compute0
> > igt@...gpu/amd_cp_dma_misc@...m_to_vram-amdgpu_hw_ip_compute0
>
>
> Could it be that we used BO list with zero entries for those?

Yes.  Dropping the 0 check fixed them.  E.g.,

+       if (in->bo_number > USHRT_MAX)
+               return -EINVAL;

Alex

>
> Christian.
>
> >
> > Alex
> >
> >>
> >> On Tue, Apr 22, 2025 at 5:13 AM Koenig, Christian <Christian.Koenig@....com>
> >> wrote:
> >>>
> >>> [AMD Official Use Only - AMD Internal Distribution Only]
> >>>
> >>> Reviewed-by: Christian König <christian.koenig@....com>
> >>>
> >>> ________________________________________
> >>> Von: Denis Arefev <arefev@...mel.ru>
> >>> Gesendet: Freitag, 18. April 2025 10:31
> >>> An: Deucher, Alexander
> >>> Cc: Koenig, Christian; David Airlie; Simona Vetter; Andrey Grodzovsky;
> >>> Chunming Zhou; amd-gfx@...ts.freedesktop.org;
> >>> dri-devel@...ts.freedesktop.org; linux-kernel@...r.kernel.org;
> >>> lvc-project@...uxtesting.org; stable@...r.kernel.org
> >>> Betreff: [PATCH v2] drm/amdgpu: check a user-provided number of BOs in
> >>> list
> >>>
> >>> The user can set any value to the variable ‘bo_number’, via the ioctl
> >>> command DRM_IOCTL_AMDGPU_BO_LIST. This will affect the arithmetic
> >>> expression ‘in->bo_number * in->bo_info_size’, which is prone to
> >>> overflow. Add a valid value check.
> >>>
> >>> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> >>>
> >>> Fixes: 964d0fbf6301 ("drm/amdgpu: Allow to create BO lists in CS ioctl
> >>> v3")
> >>> Cc: stable@...r.kernel.org
> >>> Signed-off-by: Denis Arefev <arefev@...mel.ru>
> >>> ---
> >>> V1 -> V2:
> >>> Set a reasonable limit 'USHRT_MAX' for 'bo_number' it as Christian
> >>> König <christian.koenig@....com> suggested
> >>>
> >>>  drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c | 3 +++
> >>>  1 file changed, 3 insertions(+)
> >>>
> >>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c
> >>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c
> >>> index 702f6610d024..85f7ee1e085d 100644
> >>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c
> >>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c
> >>> @@ -189,6 +189,9 @@ int amdgpu_bo_create_list_entry_array(struct
> >> drm_amdgpu_bo_list_in *in,
> >>>         struct drm_amdgpu_bo_list_entry *info;
> >>>         int r;
> >>>
> >>> +       if (!in->bo_number || in->bo_number > USHRT_MAX)
> >>> +               return -EINVAL;
> >>> +
> >>>         info = kvmalloc_array(in->bo_number, info_size, GFP_KERNEL);
> >>>         if (!info)
> >>>                 return -ENOMEM;
> >>> --
> >>> 2.43.0
> >>>
>