linux-kernel - RE: [PATCH 1/1] EDAC/i10nm: Fix the bitwise operation between variables of different sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ1PR11MB608326A2754787068FAF7E89FC852@SJ1PR11MB6083.namprd11.prod.outlook.com>
Date: Thu, 24 Apr 2025 15:46:47 +0000
From: "Luck, Tony" <tony.luck@...el.com>
To: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
CC: Dan Carpenter <dan.carpenter@...aro.org>, Borislav Petkov <bp@...en8.de>,
	James Morse <james.morse@....com>, Mauro Carvalho Chehab
	<mchehab@...nel.org>, Robert Richter <rric@...nel.org>, "Lai, Yi1"
	<yi1.lai@...el.com>, "linux-edac@...r.kernel.org"
	<linux-edac@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/1] EDAC/i10nm: Fix the bitwise operation between
 variables of different sizes

> The tool of Smatch static checker reported the following warning:
>
>   drivers/edac/i10nm_base.c:364 show_retry_rd_err_log()
>   warn: should bitwise negate be 'ullong'?
>
> This warning was due to the bitwise NOT/AND operations between
> 'status_mask' (a u32 type) and 'log' (a u64 type), which resulted in
> the high 32 bits of 'log' were cleared.
>
> This was a false positive warning, as only the low 32 bits of 'log' was
> written to the first RRL memory controller register (a u32 type).
>
> To improve code sanity, fix this warning by changing 'status_mask' to
> a u64 type, ensuring it matches the size of 'log' for bitwise operations.
>
> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> Closes: https://lore.kernel.org/all/aAih0KmEVq7ch6v2@stanley.mountain/
> Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@...el.com>

Applied. Thanks.

-Tony