linux-kernel - Re: [PATCH v6 0/2] uio_hv_generic: Fix ring buffer sysfs creation path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ac09e74-8a30-47f7-b0e3-9e759ee98f00@linux.microsoft.com>
Date: Thu, 24 Apr 2025 21:43:09 +0530
From: Naman Jain <namjain@...ux.microsoft.com>
To: Michael Kelley <mhklinux@...look.com>,
 "K . Y . Srinivasan" <kys@...rosoft.com>,
 Haiyang Zhang <haiyangz@...rosoft.com>, Wei Liu <wei.liu@...nel.org>,
 Dexuan Cui <decui@...rosoft.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Stephen Hemminger <stephen@...workplumber.org>
Cc: "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "stable@...nel.org" <stable@...nel.org>,
 Saurabh Sengar <ssengar@...ux.microsoft.com>
Subject: Re: [PATCH v6 0/2] uio_hv_generic: Fix ring buffer sysfs creation
 path

On 4/24/2025 7:18 PM, Michael Kelley wrote:
> From: Naman Jain <namjain@...ux.microsoft.com> Sent: Wednesday, April 23, 2025 10:35 PM
>>
>> Hi,
>> This patch series aims to address the sysfs creation issue for the ring
>> buffer by reorganizing the code. Additionally, it updates the ring sysfs
>> size to accurately reflect the actual ring buffer size, rather than a
>> fixed static value.
>>
>> PFB change logs:
>>
>> Changes since v5:
>> https://lore.kernel.org/all/20250415164452.170239-1-namjain@linux.microsoft.com/
>> * Added Reviewed-By tags from Dexuan. Also, addressed minor comments in
>>    commit msg of both patches.
>> * Missed to remove check for "primary_channel->device_obj->channels_kset" in
>>    hv_create_ring_sysfs in earlier patch, as suggested by Michael. Did it
>>    now.
> 
> Ah, OK :-) I thought you had decided to leave the test in, and I wasn't going to
> argue further, as it didn't hurt anything. But the test is superfluous, so the
> code is better without it. It won't mislead a future someone into thinking
> that it solves a synchronization problem.
> 
> Michael

I agree :D

Regards,
Naman

> 
>> * Changed type for declaring bin_attrs due to changes introduced by
>>    commit 9bec944506fa ("sysfs: constify attribute_group::bin_attrs") which
>>    merged recently. Did not use bin_attrs_new since another change is in
>>    the queue to change usage of bin_attrs_new to bin_attrs
>>    (sysfs: finalize the constification of 'struct bin_attribute').
>>