linux-kernel - Re: [PATCH] x86/boot: Work around broken busybox truncate tool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aApl7iqRl--uZFZE@gmail.com>
Date: Thu, 24 Apr 2025 18:25:18 +0200
From: Ingo Molnar <mingo@...nel.org>
To: phasta@...nel.org
Cc: Ard Biesheuvel <ardb+git@...gle.com>, linux-kernel@...r.kernel.org,
	x86@...nel.org, Ard Biesheuvel <ardb@...nel.org>
Subject: Re: [PATCH] x86/boot: Work around broken busybox truncate tool


* Philipp Stanner <phasta@...lbox.org> wrote:

> Thank you very much for this fix :)
> 
> On Thu, 2025-04-24 at 12:19 +0200, Ard Biesheuvel wrote:
> > From: Ard Biesheuvel <ardb@...nel.org>
> > 
> > The GNU coreutils version of truncate, which is the original, accepts
> > a
> > % prefix for the -s size argument which means the file in question
> > should be padded to a multiple of the given size. This is currently
> > used
> > to pad the setup block of bzImage to a multiple of 4k before
> > appending
> > the decompressor.
> > 
> > busybux reimplements truncate but does not support this idiom, and
> 
> typo, busybox.

Fixed, thx.

> 
> > therefore fails the build since commit
> > 
> >   9c54baab4401 ("x86/boot: Drop CRC-32 checksum and the build tool
> > that generates it")
> 
> Should this be marked as an official bug?
> 
> If so, I'd put this as a Fixes: tag below.

So I've added a Fixes tag, because it's informative, but 9c54baab4401 
is new in v6.15-rc1 so there's no backporting need.

> > Work around this by avoiding truncate altogether, and relying on dd
> > to
> > perform the padding.
> > 
> > Reported-by: <phasta@...nel.org>
> 
> Tested-by: Philipp Stanner <phasta@...nel.org>

Thanks!

	Ingo