linux-kernel - Re: [PATCH v2] mm, slab: clean up slab->obj

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aApoFXmDE-k2KFFV@black.fi.intel.com>
Date: Thu, 24 Apr 2025 19:34:29 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Zhenhua Huang <quic_zhenhuah@...cinc.com>
Cc: cl@...ux.com, rientjes@...gle.com, vbabka@...e.cz,
	roman.gushchin@...ux.dev, harry.yoo@...cle.com, surenb@...gle.com,
	pasha.tatashin@...een.com, akpm@...ux-foundation.org,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	quic_tingweiz@...cinc.com, stable@...r.kernel.org
Subject: Re: [PATCH v2] mm, slab: clean up slab->obj_exts always

On Mon, Apr 21, 2025 at 03:52:32PM +0800, Zhenhua Huang wrote:
> When memory allocation profiling is disabled at runtime or due to an
> error, shutdown_mem_profiling() is called: slab->obj_exts which
> previously allocated remains.
> It won't be cleared by unaccount_slab() because of
> mem_alloc_profiling_enabled() not true. It's incorrect, slab->obj_exts
> should always be cleaned up in unaccount_slab() to avoid following error:
> 
> [...]BUG: Bad page state in process...
> ..
> [...]page dumped because: page still charged to cgroup

Please, always compile test with `make W=1`. Since CONFIG_WERROR=y this
effectively breaks the build with Clang.

-- 
With Best Regards,
Andy Shevchenko