linux-kernel - Re: [PATCH net-next] rtase: Modify the format specifier in snprintf to %u.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aApuE3xTASb0vm9H@LQ3V64L9R2>
Date: Thu, 24 Apr 2025 10:00:03 -0700
From: Joe Damato <jdamato@...tly.com>
To: Justin Lai <justinlai0215@...ltek.com>
Cc: kuba@...nel.org, davem@...emloft.net, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	horms@...nel.org, pkshih@...ltek.com, larry.chiu@...ltek.com
Subject: Re: [PATCH net-next] rtase: Modify the format specifier in snprintf
 to %u.

On Thu, Apr 24, 2025 at 02:27:46PM +0800, Justin Lai wrote:
> Modify the format specifier in snprintf to %u.
> 
> Fixes: ea244d7d8dce ("rtase: Implement the .ndo_open function")
> Signed-off-by: Justin Lai <justinlai0215@...ltek.com>
> ---
>  drivers/net/ethernet/realtek/rtase/rtase_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/realtek/rtase/rtase_main.c b/drivers/net/ethernet/realtek/rtase/rtase_main.c
> index 8c902eaeb5ec..5996b13572c9 100644
> --- a/drivers/net/ethernet/realtek/rtase/rtase_main.c
> +++ b/drivers/net/ethernet/realtek/rtase/rtase_main.c
> @@ -1114,7 +1114,7 @@ static int rtase_open(struct net_device *dev)
>  		/* request other interrupts to handle multiqueue */
>  		for (i = 1; i < tp->int_nums; i++) {
>  			ivec = &tp->int_vector[i];
> -			snprintf(ivec->name, sizeof(ivec->name), "%s_int%i",
> +			snprintf(ivec->name, sizeof(ivec->name), "%s_int%u",
>  				 tp->dev->name, i);
>  			ret = request_irq(ivec->irq, rtase_q_interrupt, 0,
>  					  ivec->name, ivec);

Same comment as the other patch: not sure if there is a bug out in
the wild for this (seems unlikely since i is u16), so I think this
is cleanup for net-next despite having a Fixes.

Reviewed-by: Joe Damato <jdamato@...tly.com>