linux-kernel - Re: [PATCH] bpf, docs: iterator: Rectify non-standard line break

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f5ac4ab8-bd1a-4009-bf09-1ac34eb47ec1@linux.dev>
Date: Thu, 24 Apr 2025 11:06:59 +0800
From: Yanteng Si <si.yanteng@...ux.dev>
To: WangYuli <wangyuli@...ontech.com>, ast@...nel.org, daniel@...earbox.net,
 andrii@...nel.org, martin.lau@...ux.dev, eddyz87@...il.com, song@...nel.org,
 yonghong.song@...ux.dev, john.fastabend@...il.com, kpsingh@...nel.org,
 sdf@...ichev.me, haoluo@...gle.com, jolsa@...nel.org, corbet@....net
Cc: bpf@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, void@...ifault.com, psreep@...il.com,
 yhs@...com, zhanjun@...ontech.com, niecheng1@...ontech.com,
 guanwentao@...ontech.com, Chen Linxuan <chenlinxuan@...ontech.com>
Subject: Re: [PATCH] bpf, docs: iterator: Rectify non-standard line break


在 4/23/25 11:06 AM, WangYuli 写道:
> Even though the kernel's coding-style document does not explicitly
> state this, we generally put a newline after the semicolon of every
> C language statement to enhance code readability.
>
> Adjust the placement of newlines to adhere to this convention.
>
> Reported-by: Chen Linxuan <chenlinxuan@...ontech.com>
> Signed-off-by: WangYuli <wangyuli@...ontech.com>

Reviewed-by: Yanteng Si <si.yanteng@...ux.dev>


Thanks,

Yanteng

> ---
>   Documentation/bpf/bpf_iterators.rst | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/bpf/bpf_iterators.rst b/Documentation/bpf/bpf_iterators.rst
> index 7f514cb6b052..385cd05aabf5 100644
> --- a/Documentation/bpf/bpf_iterators.rst
> +++ b/Documentation/bpf/bpf_iterators.rst
> @@ -323,8 +323,8 @@ Now, in the userspace program, pass the pointer of struct to the
>   
>   ::
>   
> -  link = bpf_program__attach_iter(prog, &opts); iter_fd =
> -  bpf_iter_create(bpf_link__fd(link));
> +  link = bpf_program__attach_iter(prog, &opts);
> +  iter_fd = bpf_iter_create(bpf_link__fd(link));
>   
>   If both *tid* and *pid* are zero, an iterator created from this struct
>   ``bpf_iter_attach_opts`` will include every opened file of every task in the