linux-kernel - Re: [PATCH v1 1/1] mm, slab: fold need_slab_obj

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <691b0ba9-7587-4663-8aa3-8ce63ef509c6@suse.cz>
Date: Thu, 24 Apr 2025 19:15:00 +0200
From: Vlastimil Babka <vbabka@...e.cz>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Cc: Christoph Lameter <cl@...two.org>, David Rientjes <rientjes@...gle.com>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Roman Gushchin <roman.gushchin@...ux.dev>, Harry Yoo <harry.yoo@...cle.com>,
 Nathan Chancellor <nathan@...nel.org>,
 Nick Desaulniers <nick.desaulniers+lkml@...il.com>,
 Bill Wendling <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>,
 Zhenhua Huang <quic_zhenhuah@...cinc.com>
Subject: Re: [PATCH v1 1/1] mm, slab: fold need_slab_obj_ext() into its only
 user

On 4/24/25 18:48, Andy Shevchenko wrote:
> need_slab_obj_ext() is used only in one place, fold it into there.
> Without that, clang can't build kernel with `make W=1` when
> CONFIG_WERROR=y, which is default in the x86 configurations.

Note that gcc doesn't warn on this even with W=1.

Is really clang + W=1 + CONFIG_WERROR building ok these days except this one
unused function?

> mm/slub.c:2079:20: error: unused function 'need_slab_obj_ext' [-Werror,-Wunused-function]
> 
> To solve this, fold need_slab_obj_ext() into its only user.
> 
> Fixes: e33b7ae3d802 ("mm, slab: clean up slab->obj_exts always")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Thanks, I've folded the fix in.