linux-kernel - Re: [PATCH] btrfs: a small cleanup in attach_eb_folio_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250424184534.GN3659@twin.jikos.cz>
Date: Thu, 24 Apr 2025 20:45:34 +0200
From: David Sterba <dsterba@...e.cz>
To: Daniel Vacek <neelx@...e.com>
Cc: Chris Mason <clm@...com>, Josef Bacik <josef@...icpanda.com>,
	David Sterba <dsterba@...e.com>, linux-btrfs@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] btrfs: a small cleanup in attach_eb_folio_to_filemap()

On Wed, Apr 23, 2025 at 10:51:22AM +0200, Daniel Vacek wrote:
> This is just a trivial change. The code looks a bit more readable this way, IMO.

Please be more descriptive in the changelogs, the subject and text is
too generic. Something like "move the initializations of folio to the
beginning of the retry loop". Otherwise agreed taht it's better this
way. I'll update the changelog when adding it to for-next. Thanks.

> Signed-off-by: Daniel Vacek <neelx@...e.com>

Reviewed-by: David Sterba <dsterba@...e.com>