| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20250424-drm-bridge-convert-to-alloc-api-v2-0-8f91a404d86b@bootlin.com>
Date: Thu, 24 Apr 2025 20:59:07 +0200
From: Luca Ceresoli <luca.ceresoli@...tlin.com>
To: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
Andrzej Hajda <andrzej.hajda@...el.com>,
Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>,
Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>,
Jagan Teki <jagan@...rulasolutions.com>, Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
Douglas Anderson <dianders@...omium.org>,
Chun-Kuang Hu <chunkuang.hu@...nel.org>,
Krzysztof Kozlowski <krzk@...nel.org>
Cc: Anusha Srivatsa <asrivats@...hat.com>,
Paul Kocialkowski <paulk@...-base.io>, Dmitry Baryshkov <lumag@...nel.org>,
Hui Pu <Hui.Pu@...ealthcare.com>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
dri-devel@...ts.freedesktop.org, asahi@...ts.linux.dev,
linux-kernel@...r.kernel.org, chrome-platform@...ts.linux.dev,
imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, linux-amlogic@...ts.infradead.org,
linux-renesas-soc@...r.kernel.org, platform-driver-x86@...r.kernel.org,
linux-samsung-soc@...r.kernel.org, linux-arm-msm@...r.kernel.org,
freedreno@...ts.freedesktop.org, linux-stm32@...md-mailman.stormreply.com,
Luca Ceresoli <luca.ceresoli@...tlin.com>, Adam Ford <aford173@...il.com>,
Adrien Grassein <adrien.grassein@...il.com>,
Aleksandr Mishin <amishin@...rgos.ru>, Andy Yan <andy.yan@...k-chips.com>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
Benson Leung <bleung@...omium.org>, Biju Das <biju.das.jz@...renesas.com>,
Christoph Fritz <chf.fritz@...glemail.com>,
Cristian Ciocaltea <cristian.ciocaltea@...labora.com>,
Detlev Casanova <detlev.casanova@...labora.com>,
Dharma Balasubiramani <dharma.b@...rochip.com>,
Guenter Roeck <groeck@...omium.org>, Heiko Stuebner <heiko@...ech.de>,
Jani Nikula <jani.nikula@...el.com>, Janne Grunau <j@...nau.net>,
Jerome Brunet <jbrunet@...libre.com>, Jesse Van Gavere <jesseevg@...il.com>,
Kevin Hilman <khilman@...libre.com>,
Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
Liu Ying <victor.liu@....com>,
Manikandan Muralidharan <manikandan.m@...rochip.com>,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
Matthias Brugger <matthias.bgg@...il.com>,
Philipp Zabel <p.zabel@...gutronix.de>, Phong LE <ple@...libre.com>,
Sasha Finkelstein <fnkl.kernel@...il.com>,
Sugar Zhang <sugar.zhang@...k-chips.com>,
Sui Jingfeng <sui.jingfeng@...ux.dev>,
Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>,
Vitalii Mordan <mordan@...ras.ru>,
Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
Hans de Goede <hdegoede@...hat.com>,
Uwe Kleine-König <u.kleine-koenig@...libre.com>,
Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
"Rob Herring (Arm)" <robh@...nel.org>,
Hsin-Te Yuan <yuanhsinte@...omium.org>,
Pin-yen Lin <treapking@...omium.org>, Xin Ji <xji@...logixsemi.com>,
Aradhya Bhatia <a-bhatia1@...com>,
Tomi Valkeinen <tomi.valkeinen@...asonboard.com>, Ian Ray <ian.ray@...com>,
Martyn Welch <martyn.welch@...labora.co.uk>,
Peter Senna Tschudin <peter.senna@...il.com>,
Russell King <linux@...linux.org.uk>,
Herve Codina <herve.codina@...tlin.com>,
Alim Akhtar <alim.akhtar@...sung.com>, Inki Dae <inki.dae@...sung.com>,
Kyungmin Park <kyungmin.park@...sung.com>,
Seung-Woo Kim <sw0312.kim@...sung.com>,
Linus Walleij <linus.walleij@...aro.org>,
Abhinav Kumar <quic_abhinavk@...cinc.com>,
Bjorn Andersson <quic_bjorande@...cinc.com>,
Marijn Suijten <marijn.suijten@...ainline.org>,
Rob Clark <robdclark@...il.com>, Sean Paul <sean@...rly.run>,
Helge Deller <deller@....de>,
Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Philippe Cornu <philippe.cornu@...s.st.com>,
Raphael Gallais-Pou <raphael.gallais-pou@...s.st.com>,
Yannick Fertre <yannick.fertre@...s.st.com>,
Maíra Canal <mcanal@...lia.com>,
Dave Stevenson <dave.stevenson@...pberrypi.com>,
Raspberry Pi Kernel Maintenance <kernel-list@...pberrypi.com>,
Alain Volmat <alain.volmat@...s.st.com>,
Raphael Gallais-Pou <rgallaispou@...il.com>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Michal Simek <michal.simek@....com>
Subject: [PATCH v2 00/34] drm: convert all bridges to
devm_drm_bridge_alloc()
devm_drm_bridge_alloc() [0] is the new API to allocate and initialize a DRM
bridge, and the only one supported from now on. It is also necessary for
implementing reference counting and thus needed to support removal of
bridges from a still existing DRM pipeline without use-after-free.
This series converts all DRM bridges to the new API.
Patch 1 uses a coccinelle semantic patch to mass-convert some of those
drivers -- thanks Maxime for having suggested the patch that served as a
starting point for me. I was unable to come up with a better patch
converting more drivers though, so I converted all others manually. Most of
them were trivial. I left the non-trivial ones at the end of the series to
help reviewers know where to look at more carefully.
Due to the large number of touched files, the list of recipients generated
by get_maintainers (b4 actually) was huge, 60~70 people (not counting
mailing lists), so I took the liberty of trimming the list as reasonably as
I could to DRM maintainers and frequent contributors, and added all other
recipients individually per-patch. I hope this is fine. Don't hesitate to
suggest more people which should be Cc-ed in a future series, or a better
Cc policy.
Current plan and status of the DRM bridge refcounting work:
A. ✔ add new alloc API and refcounting -> (now in drm-misc-next)
B. ➜ convert all bridge drivers to new API (this series)
C. … documentation, kunit tests, debugfs improvements (v1 under discussion)
D. after (B), add get/put to drm_bridge_add/remove() + attach/detech()
E. after (B), convert accessors; this is a large work and can be done
in chunks
Luca
[0] https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/0cc6aadd7fc1e629b715ea3d1ba537ef2da95eec
Signed-off-by: Luca Ceresoli <luca.ceresoli@...tlin.com>
---
Changes in v2:
- Improved cover letter with link to commit adding devm_drm_bridge_alloc()
- add review tags
- fix bugs in zynqmp, vc4 patches
- fix patch 1 error code checking
- Link to v1: https://lore.kernel.org/r/20250407-drm-bridge-convert-to-alloc-api-v1-0-42113ff8d9c0@bootlin.com
---
Luca Ceresoli (34):
drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API
platform: arm64: acer-aspire1-ec: convert to devm_drm_bridge_alloc() API
drm/bridge: analogix-anx6345: convert to devm_drm_bridge_alloc() API
drm/bridge: anx7625: convert to devm_drm_bridge_alloc() API
drm/bridge: cdns-dsi: convert to devm_drm_bridge_alloc() API
drm/bridge: display-connector: convert to devm_drm_bridge_alloc() API
drm/bridge: lt9611uxc: convert to devm_drm_bridge_alloc() API
drm/bridge: megachips-stdpxxxx-ge-b850v3-fw: convert to devm_drm_bridge_alloc() API
drm/bridge: nxp-ptn3460: convert to devm_drm_bridge_alloc() API
drm/bridge: sii902x: convert to devm_drm_bridge_alloc() API
drm/bridge: dw-hdmi: convert to devm_drm_bridge_alloc() API
drm/bridge: tda998x: convert to devm_drm_bridge_alloc() API
drm/bridge: ti-sn65dsi86: convert to devm_drm_bridge_alloc() API
drm/exynos: mic: convert to devm_drm_bridge_alloc() API
drm/mcde: convert to devm_drm_bridge_alloc() API
drm/msm/dp: convert to devm_drm_bridge_alloc() API
drm/msm/dsi: convert to devm_drm_bridge_alloc() API
drm/msm/hdmi: convert to devm_drm_bridge_alloc() API
drm/omap: dss: dpi: convert to devm_drm_bridge_alloc() API
drm/omap: dss: dsi: convert to devm_drm_bridge_alloc() API
drm/omap: dss: hdmi4: convert to devm_drm_bridge_alloc() API
drm/omap: dss: hdmi5: convert to devm_drm_bridge_alloc() API
drm/omap: dss: sdi: convert to devm_drm_bridge_alloc() API
drm/omap: dss: venc: convert to devm_drm_bridge_alloc() API
drm/rcar-du: dsi: convert to devm_drm_bridge_alloc() API
drm/bridge: stm_lvds: convert to devm_drm_bridge_alloc() API
drm/vc4: convert to devm_drm_bridge_alloc() API
drm/sti: dvo: convert to devm_drm_bridge_alloc() API
drm: zynqmp_dp: convert to devm_drm_bridge_alloc() API
drm/bridge: imx8qxp-pixel-combiner: convert to devm_drm_bridge_alloc() API
drm/bridge: imx8*-ldb: convert to devm_drm_bridge_alloc() API
drm/bridge: tc358767: convert to devm_drm_bridge_alloc() API
drm/bridge: add devm_drm_put_bridge()
drm/bridge: panel: convert to devm_drm_bridge_alloc() API
drivers/gpu/drm/adp/adp-mipi.c | 8 ++--
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 ++--
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 8 ++--
drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 9 ++--
drivers/gpu/drm/bridge/analogix/anx7625.c | 7 ++-
drivers/gpu/drm/bridge/aux-bridge.c | 9 ++--
drivers/gpu/drm/bridge/aux-hpd-bridge.c | 9 ++--
drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 8 ++--
.../gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 8 ++--
drivers/gpu/drm/bridge/chipone-icn6211.c | 9 ++--
drivers/gpu/drm/bridge/chrontel-ch7033.c | 8 ++--
drivers/gpu/drm/bridge/cros-ec-anx7688.c | 9 ++--
drivers/gpu/drm/bridge/display-connector.c | 8 ++--
drivers/gpu/drm/bridge/fsl-ldb.c | 7 ++-
drivers/gpu/drm/bridge/imx/imx-ldb-helper.c | 4 +-
drivers/gpu/drm/bridge/imx/imx-ldb-helper.h | 3 +-
drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c | 9 ++--
drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c | 10 ++--
drivers/gpu/drm/bridge/imx/imx8qm-ldb.c | 32 ++++++++-----
drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c | 20 +++++---
.../gpu/drm/bridge/imx/imx8qxp-pixel-combiner.c | 18 ++++---
drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c | 8 ++--
drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c | 8 ++--
drivers/gpu/drm/bridge/ite-it6263.c | 9 ++--
drivers/gpu/drm/bridge/ite-it6505.c | 9 ++--
drivers/gpu/drm/bridge/ite-it66121.c | 9 ++--
drivers/gpu/drm/bridge/lontium-lt8912b.c | 9 ++--
drivers/gpu/drm/bridge/lontium-lt9211.c | 8 ++--
drivers/gpu/drm/bridge/lontium-lt9611.c | 9 ++--
drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 7 ++-
drivers/gpu/drm/bridge/lvds-codec.c | 9 ++--
.../drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c | 11 ++---
drivers/gpu/drm/bridge/microchip-lvds.c | 8 ++--
drivers/gpu/drm/bridge/nwl-dsi.c | 8 ++--
drivers/gpu/drm/bridge/nxp-ptn3460.c | 9 ++--
drivers/gpu/drm/bridge/panel.c | 11 ++---
drivers/gpu/drm/bridge/parade-ps8622.c | 9 ++--
drivers/gpu/drm/bridge/parade-ps8640.c | 9 ++--
drivers/gpu/drm/bridge/sii902x.c | 7 ++-
drivers/gpu/drm/bridge/sii9234.c | 9 ++--
drivers/gpu/drm/bridge/sil-sii8620.c | 9 ++--
drivers/gpu/drm/bridge/simple-bridge.c | 10 ++--
drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 8 ++--
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 7 ++-
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 8 ++--
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi2.c | 8 ++--
drivers/gpu/drm/bridge/tc358762.c | 9 ++--
drivers/gpu/drm/bridge/tc358764.c | 9 ++--
drivers/gpu/drm/bridge/tc358767.c | 56 +++++++++++++++-------
drivers/gpu/drm/bridge/tc358768.c | 9 ++--
drivers/gpu/drm/bridge/tc358775.c | 9 ++--
drivers/gpu/drm/bridge/tda998x_drv.c | 7 ++-
drivers/gpu/drm/bridge/thc63lvd1024.c | 8 ++--
drivers/gpu/drm/bridge/ti-dlpc3433.c | 9 ++--
drivers/gpu/drm/bridge/ti-sn65dsi86.c | 7 ++-
drivers/gpu/drm/bridge/ti-tdp158.c | 8 ++--
drivers/gpu/drm/bridge/ti-tfp410.c | 9 ++--
drivers/gpu/drm/bridge/ti-tpd12s015.c | 9 ++--
drivers/gpu/drm/drm_bridge.c | 14 ++++++
drivers/gpu/drm/exynos/exynos_drm_mic.c | 7 ++-
drivers/gpu/drm/mcde/mcde_dsi.c | 7 ++-
drivers/gpu/drm/mediatek/mtk_dp.c | 9 ++--
drivers/gpu/drm/mediatek/mtk_dpi.c | 9 ++--
drivers/gpu/drm/mediatek/mtk_dsi.c | 9 ++--
drivers/gpu/drm/mediatek/mtk_hdmi.c | 9 ++--
drivers/gpu/drm/meson/meson_encoder_cvbs.c | 12 ++---
drivers/gpu/drm/meson/meson_encoder_dsi.c | 12 ++---
drivers/gpu/drm/meson/meson_encoder_hdmi.c | 12 ++---
drivers/gpu/drm/msm/dp/dp_drm.c | 9 ++--
drivers/gpu/drm/msm/dsi/dsi_manager.c | 9 ++--
drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 9 ++--
drivers/gpu/drm/omapdrm/dss/dpi.c | 7 ++-
drivers/gpu/drm/omapdrm/dss/dsi.c | 7 ++-
drivers/gpu/drm/omapdrm/dss/hdmi4.c | 26 ++++------
drivers/gpu/drm/omapdrm/dss/hdmi5.c | 26 ++++------
drivers/gpu/drm/omapdrm/dss/sdi.c | 25 ++++------
drivers/gpu/drm/omapdrm/dss/venc.c | 23 ++++-----
drivers/gpu/drm/renesas/rcar-du/rcar_lvds.c | 9 ++--
drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c | 8 ++--
drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c | 10 ++--
drivers/gpu/drm/sti/sti_dvo.c | 29 +++++------
drivers/gpu/drm/stm/lvds.c | 7 ++-
drivers/gpu/drm/vc4/vc4_dsi.c | 34 ++-----------
drivers/gpu/drm/xlnx/zynqmp_dp.c | 31 +++++-------
drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 1 -
drivers/platform/arm64/acer-aspire1-ec.c | 7 ++-
include/drm/drm_bridge.h | 4 ++
87 files changed, 448 insertions(+), 510 deletions(-)
---
base-commit: 82d6ce3a9e828e73ef43b8072a89d94608ae1554
change-id: 20250404-drm-bridge-convert-to-alloc-api-614becf62294
Best regards,
--
Luca Ceresoli <luca.ceresoli@...tlin.com>
Powered by blists - more mailing lists