linux-kernel - Re: [PATCH v14 03/19] x86: Secure Launch Resource Table header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50b62527-231f-4955-9a26-f87414cb46de@oracle.com>
Date: Thu, 24 Apr 2025 12:19:54 -0700
From: ross.philipson@...cle.com
To: "Huang, Kai" <kai.huang@...el.com>,
        "kexec@...ts.infradead.org" <kexec@...ts.infradead.org>,
        "x86@...nel.org" <x86@...nel.org>,
        "linux-integrity@...r.kernel.org" <linux-integrity@...r.kernel.org>,
        "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>
Cc: "corbet@....net" <corbet@....net>, "ardb@...nel.org" <ardb@...nel.org>,
        "andrew.cooper3@...rix.com" <andrew.cooper3@...rix.com>,
        "peterhuewe@....de" <peterhuewe@....de>,
        "James.Bottomley@...senpartnership.com"
 <James.Bottomley@...senpartnership.com>,
        "trenchboot-devel@...glegroups.com" <trenchboot-devel@...glegroups.com>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "baolu.lu@...ux.intel.com" <baolu.lu@...ux.intel.com>,
        "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "Ghatraju, Kanth" <kanth.ghatraju@...cle.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "luto@...capital.net" <luto@...capital.net>,
        "dwmw2@...radead.org" <dwmw2@...radead.org>,
        "dpsmith@...rtussolutions.com" <dpsmith@...rtussolutions.com>,
        "jarkko@...nel.org" <jarkko@...nel.org>,
        "ebiederm@...ssion.com" <ebiederm@...ssion.com>,
        "hpa@...or.com" <hpa@...or.com>, "bp@...en8.de" <bp@...en8.de>,
        "mjg59@...f.ucam.org" <mjg59@...f.ucam.org>,
        "jgg@...pe.ca" <jgg@...pe.ca>,
        "nivedita@...m.mit.edu" <nivedita@...m.mit.edu>
Subject: Re: [PATCH v14 03/19] x86: Secure Launch Resource Table header file

On 4/24/25 5:36 AM, Huang, Kai wrote:
> 
>> +
>> +#ifndef __ASSEMBLY__
>>
> [...]
> 
>> +#endif /* !__ASSEMBLY */
>>
> 
> A minor thing:
> 
> There's an attempt to convert __ASSEMBLY__ to __ASSEMBLER__ at tree-wide level:
> 
> https://urldefense.com/v3/__https://lore.kernel.org/lkml/20250314071013.1575167-1-thuth@redhat.com/__;!!ACWV5N9M2RV99hQ!MhSEDY0kYk37uZxtStR43EmL_ySswhslosStYlSCe97P72GzkHTmhJQsz9okEBy6HDQOCAWJkyV7mvRkYcA89g$
> 
> I am not sure the final result (there's some discussion around uapi part, but it
> seems there's no objection to changes to the headers visible only to the
> kernel), but the x86 ones have been merged:
> 
>        x86/headers: Replace __ASSEMBLY__ with __ASSEMBLER__ in non-UAPI headers
>        x86/headers: Replace __ASSEMBLY__ with __ASSEMBLER__ in UAPI headers
> 
> So perhaps we should use __ASSEMBLER__ for the new code.

Yes good call. I see a number of those patches to switch to 
__ASSEMBLER__ are already in.

Thanks
Ross