linux-kernel - Re: [PATCH v1 1/1] mm, slab: fold need_slab_obj

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202504250400.BLLCAX1T-lkp@intel.com>
Date: Fri, 25 Apr 2025 04:35:54 +0800
From: kernel test robot <lkp@...el.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Vlastimil Babka <vbabka@...e.cz>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Cc: oe-kbuild-all@...ts.linux.dev,
	Christoph Lameter <cl@...ux-foundation.org>,
	David Rientjes <rientjes@...gle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Memory Management List <linux-mm@...ck.org>,
	Roman Gushchin <roman.gushchin@...ux.dev>,
	Harry Yoo <harry.yoo@...cle.com>,
	Nathan Chancellor <nathan@...nel.org>,
	Nick Desaulniers <nick.desaulniers+lkml@...il.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH v1 1/1] mm, slab: fold need_slab_obj_ext() into its only
 user

Hi Andy,

kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-everything]

url:    https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/mm-slab-fold-need_slab_obj_ext-into-its-only-user/20250425-004842
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20250424164800.2658961-1-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v1 1/1] mm, slab: fold need_slab_obj_ext() into its only user
config: i386-buildonly-randconfig-001-20250425 (https://download.01.org/0day-ci/archive/20250425/202504250400.BLLCAX1T-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250425/202504250400.BLLCAX1T-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504250400.BLLCAX1T-lkp@intel.com/

All errors (new ones prefixed by >>):

   mm/slub.c: In function 'unaccount_slab':
>> mm/slub.c:2591:36: error: implicit declaration of function 'need_slab_obj_ext'; did you mean 'free_slab_obj_exts'? [-Werror=implicit-function-declaration]
    2591 |         if (memcg_kmem_online() || need_slab_obj_ext())
         |                                    ^~~~~~~~~~~~~~~~~
         |                                    free_slab_obj_exts
   cc1: some warnings being treated as errors


vim +2591 mm/slub.c

0bedcc66d2a43a5 Vlastimil Babka    2023-10-03  2587  
0bedcc66d2a43a5 Vlastimil Babka    2023-10-03  2588  static __always_inline void unaccount_slab(struct slab *slab, int order,
0bedcc66d2a43a5 Vlastimil Babka    2023-10-03  2589  					   struct kmem_cache *s)
0bedcc66d2a43a5 Vlastimil Babka    2023-10-03  2590  {
4b8736964640fe1 Suren Baghdasaryan 2024-03-21 @2591  	if (memcg_kmem_online() || need_slab_obj_ext())
21c690a349baab8 Suren Baghdasaryan 2024-03-21  2592  		free_slab_obj_exts(slab);
0bedcc66d2a43a5 Vlastimil Babka    2023-10-03  2593  
0bedcc66d2a43a5 Vlastimil Babka    2023-10-03  2594  	mod_node_page_state(slab_pgdat(slab), cache_vmstat_idx(s),
0bedcc66d2a43a5 Vlastimil Babka    2023-10-03  2595  			    -(PAGE_SIZE << order));
0bedcc66d2a43a5 Vlastimil Babka    2023-10-03  2596  }
0bedcc66d2a43a5 Vlastimil Babka    2023-10-03  2597  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki