linux-kernel - Re: [PATCH next] phy: tegra: xusb: remove a stray unlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a153d595-cc77-4996-a9d5-9ac0497b9e82@nvidia.com>
Date: Thu, 24 Apr 2025 08:30:24 +0100
From: Jon Hunter <jonathanh@...dia.com>
To: Dan Carpenter <dan.carpenter@...aro.org>, Wayne Chang <waynec@...dia.com>
Cc: JC Kuo <jckuo@...dia.com>, Vinod Koul <vkoul@...nel.org>,
 Kishon Vijay Abraham I <kishon@...nel.org>,
 Thierry Reding <thierry.reding@...il.com>, linux-phy@...ts.infradead.org,
 linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] phy: tegra: xusb: remove a stray unlock


On 23/04/2025 14:08, Dan Carpenter wrote:
> We used to take a lock in tegra186_utmi_bias_pad_power_on() but now we
> have moved the lock into the caller.  Unfortunately, when we moved the
> lock this unlock was left behind and it results in a double unlock.
> Delete it now.
> 
> Fixes: b47158fb4295 ("phy: tegra: xusb: Use a bitmask for UTMI pad power state tracking")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>   drivers/phy/tegra/xusb-tegra186.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/xusb-tegra186.c
> index cc7b8a6a999f..23a23f2d64e5 100644
> --- a/drivers/phy/tegra/xusb-tegra186.c
> +++ b/drivers/phy/tegra/xusb-tegra186.c
> @@ -656,8 +656,6 @@ static void tegra186_utmi_bias_pad_power_on(struct tegra_xusb_padctl *padctl)
>   	} else {
>   		clk_disable_unprepare(priv->usb2_trk_clk);
>   	}
> -
> -	mutex_unlock(&padctl->lock);
>   }
>   
>   static void tegra186_utmi_bias_pad_power_off(struct tegra_xusb_padctl *padctl)


Reviewed-by: Jon Hunter <jonathanh@...dia.com>

Thanks for catching and fixing this!

Jon

-- 
nvpublic