linux-kernel - Re: [PATCH v5 0/2] sched/numa: Skip VMA scanning on memory pinned to one NUMA node via cpuset.mems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aabedb46-8fce-4f4f-823d-b1ef7b440c8e@amd.com>
Date: Thu, 24 Apr 2025 13:22:11 +0530
From: "Aithal, Srikanth" <sraithal@....com>
To: Libo Chen <libo.chen@...cle.com>, akpm@...ux-foundation.org,
 rostedt@...dmis.org, peterz@...radead.org, mgorman@...e.de,
 mingo@...hat.com, juri.lelli@...hat.com, vincent.guittot@...aro.org,
 tj@...nel.org, llong@...hat.com
Cc: venkat88@...ux.ibm.com, kprateek.nayak@....com, raghavendra.kt@....com,
 yu.c.chen@...el.com, tim.c.chen@...el.com, vineethr@...ux.ibm.com,
 chris.hyser@...cle.com, daniel.m.jordan@...cle.com,
 lorenzo.stoakes@...cle.com, mkoutny@...e.com, linux-mm@...ck.org,
 cgroups@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 0/2] sched/numa: Skip VMA scanning on memory pinned to
 one NUMA node via cpuset.mems

On 4/24/2025 8:15 AM, Libo Chen wrote:
> v1->v2:
> 1. add perf improvment numbers in commit log. Yet to find perf diff on
> will-it-scale, so not included here. Plan to run more workloads.
> 2. add tracepoint.
> 3. To peterz's comment, this will make it impossible to attract tasks to
> those memory just like other VMA skippings. This is the current
> implementation, I think we can improve that in the future, but at the
> moment it's probabaly better to keep it consistent.
> 
> v2->v3:
> 1. add enable_cpuset() based on Mel's suggestion but again I think it's
> redundant.
> 2. print out nodemask with %*p.. format in the tracepoint.
> 
> v3->v4:
> 1. fix an unsafe dereference of a pointer to content not on ring buffer,
> namely mem_allowed_ptr in the tracepoint.
> 
> v4->v5:
> 1. add BUILD_BUG_ON() in TP_fast_assign() to guard against future
> changes (particularly in size) in nodemask_t.
> 
> Libo Chen (2):
>    sched/numa: Skip VMA scanning on memory pinned to one NUMA node via
>      cpuset.mems
>    sched/numa: Add tracepoint that tracks the skipping of numa balancing
>      due to cpuset memory pinning
> 
>   include/trace/events/sched.h | 33 +++++++++++++++++++++++++++++++++
>   kernel/sched/fair.c          |  9 +++++++++
>   2 files changed, 42 insertions(+)
> 

Tested on top of next-20250424. The boot warning[1] is fixed with this 
version.

Tested-by: Srikanth Aithal <sraithal@....com>


[1]: https://lore.kernel.org/all/20250422205740.02c4893a@canb.auug.org.au/