linux-kernel - Re: [PATCH 5/6] arm64: dts: qcom: qcs615: add ADSP and CDSP nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <774c2476-937b-4d3a-b0dc-d66f12d9f60e@quicinc.com>
Date: Thu, 24 Apr 2025 15:56:03 +0800
From: Lijuan Gao <quic_lijuang@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        "Rob
 Herring" <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        "Conor
 Dooley" <conor+dt@...nel.org>,
        Manivannan Sadhasivam
	<manivannan.sadhasivam@...aro.org>,
        Konrad Dybcio <konradybcio@...nel.org>
CC: <kernel@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
        <linux-remoteproc@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/6] arm64: dts: qcom: qcs615: add ADSP and CDSP nodes



在 4/23/2025 5:34 PM, Konrad Dybcio 写道:
> On 4/23/25 11:17 AM, Lijuan Gao wrote:
>> Add nodes for remoteprocs: ADSP and CDSP for QCS615 SoC to enable proper
>> remoteproc functionality.
>>
>> Signed-off-by: Lijuan Gao <quic_lijuang@...cinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/qcs615.dtsi | 86 ++++++++++++++++++++++++++++++++++++
>>   1 file changed, 86 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qcom/qcs615.dtsi
>> index fe9fda6b71c4..c0e2d8699d05 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs615.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi
>> @@ -503,6 +503,16 @@ smem_region: smem@...00000 {
>>   			no-map;
>>   			hwlocks = <&tcsr_mutex 3>;
>>   		};
>> +
>> +		rproc_cdsp_mem: rproc-cdsp@...00000 {
>> +			reg = <0x0 0x93b00000 0x0 0x1e00000>;
>> +			no-map;
>> +		};
>> +
>> +		rproc_adsp_mem: rproc-adsp@...00000 {
>> +			reg = <0x0 0x95900000 0x0 0x1e00000>;
>> +			no-map;
>> +		};
> 
> Please double check these addresses, I'm not saying they're necessarily
> wrong, but I can't find a confirmation for them either
> 
After double-checking, the addresses match those on the latest memory map.
> 
>>   	};
>>   
>>   	soc: soc@0 {
>> @@ -3124,6 +3134,44 @@ cti@...0000 {
>>   			clock-names = "apb_pclk";
>>   		};
>>   
>> +		remoteproc_cdsp: remoteproc-cdsp@...0000 {
> 
> remoteproc@
> 
> [...]
> 
Understood, it will be updated in the next patch.
>> +		remoteproc_adsp: remoteproc-adsp@...00000 {
>> +			compatible = "qcom,qcs615-adsp-pas", "qcom,sm8150-adsp-pas";
>> +			reg = <0x0 0x62400000 0x0 0x100>;
> 
> The size is 0x100000 (1 MiB)

Sorry, my mistake. I checked the latest datasheet, and the size should 
be 0x4040. I will update the register size for both ADSP and CDSP
> 
> Konrad

-- 
Thx and BRs
Lijuan Gao