linux-kernel - Re: [PATCH] crypto: x86/sha256 - Include asm/fpu/api.h directly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aAmMQl7MNwhP8aPl@gondor.apana.org.au>
Date: Thu, 24 Apr 2025 08:56:34 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Arnd Bergmann <arnd@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
	Arnd Bergmann <arnd@...db.de>, "H. Peter Anvin" <hpa@...or.com>,
	Uros Bizjak <ubizjak@...il.com>, Eric Biggers <ebiggers@...nel.org>,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: x86/sha256 - Include asm/fpu/api.h directly

On Wed, Apr 23, 2025 at 06:25:45PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> This was previously included through another header, but now causes
> a build failure in some configurations:
> 
> arch/x86/crypto/sha256_ssse3_glue.c:63:2: error: call to undeclared function 'kernel_fpu_begin'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>    63 |         kernel_fpu_begin();
>       |         ^
> arch/x86/crypto/sha256_ssse3_glue.c:65:2: error: call to undeclared function 'kernel_fpu_end'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>    65 |         kernel_fpu_end();
>       |         ^
> 
> Include the header directly to make it build again.
> 
> Fixes: 8e7547473875 ("crypto: x86/sha256 - Use API partial block handling")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  arch/x86/crypto/sha256_ssse3_glue.c | 2 ++
>  1 file changed, 2 insertions(+)

Sorry, I had pushed out the wrong tree.  It should be fixed in
cryptodev already:

https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=eba187a6e7141a1166a68c4d27b4ee5a27670b3b

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt